Uh oh!
There was an error while loading. Please reload this page.
test: repl tab completion test - #5534
Closed
santigimeno wants to merge 1 commit into
Closed
Conversation
It checks that `eval` is called with `.scope` as an input string.
cjihrig
commented
Mar 2, 2016
Contributor
LGTM |
Trott
commented
Mar 2, 2016
Member
LGTM if CI likes it. CI: https://ci.nodejs.org/job/node-test-pull-request/1823/ @bnoordhuis This is the |
orangemocha
commented
Mar 3, 2016
Contributor
The CI run failed because it wasn't certified safe (sigh). Here's a new run: https://ci.nodejs.org/job/node-test-pull-request/1829/ |
jasnell
commented
Mar 21, 2016
Member
Failure is unrelated. LGTM |
jasnell pushed a commit
that referenced
this pull request
Mar 21, 2016
It checks that `eval` is called with `.scope` as an input string. PR-URL: #5534 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
commented
Mar 21, 2016
Member
Landed in c7b1270 |
Fishrock123 pushed a commit
that referenced
this pull request
Mar 22, 2016
It checks that `eval` is called with `.scope` as an input string. PR-URL: #5534 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Mar 30, 2016
It checks that `eval` is called with `.scope` as an input string. PR-URL: #5534 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Mar 30, 2016
It checks that `eval` is called with `.scope` as an input string. PR-URL: #5534 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
test,repl
Description of change
It checks that
evalis called with.scopeas an input string.It tries to fix#5232