Uh oh!
There was an error while loading. Please reload this page.
test: fix invalid file: URL in test-fs-path-dir - #55454
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #55454 +/- ##
=======================================
Coverage 88.40% 88.41% =======================================
Files 653 653 Lines 187600 187505 -95 Branches 36117 36100 -17 =======================================
- Hits 165854 165777 -77 + Misses 14974 14967 -7 + Partials 6772 6761 -11 |
LiviaMedeiros
approved these changes
Oct 19, 2024
nodejs-github-bot
commented
Oct 19, 2024
Collaborator
jakecastelli
approved these changes
Oct 19, 2024
nodejs-github-bot
commented
Oct 19, 2024
Collaborator
lpinca
approved these changes
Oct 19, 2024
nodejs-github-bot
commented
Oct 21, 2024
Collaborator
Landed in 7e60b5e |
aduh95 added a commit
that referenced
this pull request
Oct 23, 2024
PR-URL: #55454 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
ruyadorno
commented
Nov 27, 2024
Member
This commit does not land cleanly on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to build a URL by concatenating
file://and a path will always fail as soon as the path contains some URL-significant char (e.g.%,?,#)