Skip to content

meta: allow users to reopen stale issues via commands - #55498

Closed
avivkeller wants to merge 2 commits into
nodejs:mainfrom
avivkeller:patch-634036
Closed

meta: allow users to reopen stale issues via commands#55498
avivkeller wants to merge 2 commits into
nodejs:mainfrom
avivkeller:patch-634036

Conversation

@avivkeller

Copy link
Copy Markdown
Member

This is a draft as I'd love some opinions on whether this is behavior the project would like to support.

@ljharb pointed out in this thread that it would be ideal if we "can offer a stalebot command that anyone can use to reopen [the issue]".

This is a basic implemention of such commands, so I'd love some opinions on whether this behavior we'd want to support.


(@ljharb do you have anything to add?)

@avivkeller
avivkeller marked this pull request as draft October 23, 2024 13:16
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 23, 2024
@avivkeller

Copy link
Copy Markdown
MemberAuthor

BTW the cons of this is that it may slow down our actions by a few seconds, if a lot of users are commenting at the same time, and it'll clog the list of actions that ran at https://github.com/nodejs/node/actions

Also see #54672

@ljharbljharb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks

@avivkeller
avivkeller marked this pull request as ready for review October 24, 2024 21:30
@avivkelleravivkeller added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 5, 2024
Comment thread.github/workflows/comment-commands.yml
bnb
bnb approved these changes Nov 7, 2024
@bnb

bnb commented Nov 7, 2024

Copy link
Copy Markdown
Contributor

+1 but this might be something we want the @nodejs/tsc to review as it does fundamentally change how we manage issues.

@avivkeller

Copy link
Copy Markdown
MemberAuthor

Also, once this lands, we should look into landing #54672, and similar PRs

@marco-ippolitomarco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 13, 2025
@avivkeller

Copy link
Copy Markdown
MemberAuthor

Hey @marco-ippolito! I see you started to, then stopped, this PR from the queue. Is there anything I can do to get this merged? Or is the project going in a different direction or something?

Thanks!

@marco-ippolitomarco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label May 10, 2025
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 10, 2025
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/55498
✔ Done loading data for nodejs/node/pull/55498
----------------------------------- PR info ------------------------------------
Title meta: allow users to reopen stale issues via commands (#55498)
Author Aviv Keller <me@aviv.sh> (@avivkeller)
Branch avivkeller:patch-634036 -> nodejs:main
Labels meta, author ready, commit-queue-squash
Commits 2
- meta: allow users to reopen stale issues via commands
- fixup! meta: allow users to reopen stale issues via commands
Committers 2
- GitHub <noreply@github.com>
- RedYetiDev <38299977+RedYetiDev@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/55498
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/55498
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
--------------------------------------------------------------------------------
ℹ This PR was created on Wed, 23 Oct 2024 13:16:00 GMT
✔ Approvals: 3
✔ - Jordan Harband (@ljharb): https://github.com/nodejs/node/pull/55498#pullrequestreview-2389096709
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/55498#pullrequestreview-2416971837
✔ - Tierney Cyren (@bnb): https://github.com/nodejs/node/pull/55498#pullrequestreview-2421545786
✘ Last GitHub CI failed
ℹ Green GitHub CI is sufficient
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/14942808745

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, we can try this

@avivkeller

Copy link
Copy Markdown
MemberAuthor

Last GitHub CI failed

😕

@avivkeller

Copy link
Copy Markdown
MemberAuthor

Not sure what went wrong here? The GitHub CI seems green?

@targos

Copy link
Copy Markdown
Member

Maybe try to rebase?

@avivkelleravivkeller closed this by deleting the head repository Dec 18, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-failedAn error occurred while landing this pull request using GitHub Actions.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@avivkeller@nodejs-github-bot@bnb@targos@ljharb@mcollina@jasnell@aduh95@RafaelGSS@marco-ippolito