Skip to content

fs: make dirent.path writable - #55547

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
aduh95:writable-dirent-path
Oct 28, 2024
Merged

fs: make dirent.path writable#55547
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
aduh95:writable-dirent-path

Conversation

@aduh95

@aduh95aduh95 commented Oct 26, 2024

Copy link
Copy Markdown
Contributor

Refs: #55538

@aduh95aduh95 added dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Oct 26, 2024
@nodejs-github-botnodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Oct 26, 2024
@aduh95aduh95 mentioned this pull request Oct 26, 2024
Merged
@aduh95aduh95 added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 26, 2024
mcollina
mcollina approved these changes Oct 26, 2024
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 26, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2024
@nodejs-github-bot

nodejs-github-bot commented Oct 26, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63290/

@aduh95aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 26, 2024
@codecov

codecovBot commented Oct 26, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.43%. Comparing base (c63255b) to head (07ea77c).
Report is 8 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #55547 +/- ##
==========================================
- Coverage 88.43% 88.43% -0.01% 
==========================================
Files 654 654 Lines 187662 187666 +4 Branches 36117 36126 +9 ==========================================
- Hits 165962 165955 -7 - Misses 14938 14947 +9 - Partials 6762 6764 +2
Files with missing linesCoverage Δ
lib/internal/fs/utils.js99.70% <100.00%> (+<0.01%)⬆️

... and 17 files with indirect coverage changes

LiviaMedeiros
LiviaMedeiros approved these changes Oct 26, 2024
View reviewed changes

@LiviaMedeirosLiviaMedeiros left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Opened #55553 to address the test failure (the test in this PR should work as-is after rebase)

Also, I think it should be semver-patch rather than semver-minor. .path didn't became read-only intentionally, it was just a limitation due to how runtime deprecation was implemented.

@nodejs-github-bot

nodejs-github-bot commented Oct 26, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63297/

@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 26, 2024
@aduh95

aduh95 commented Oct 26, 2024

Copy link
Copy Markdown
ContributorAuthor

.path didn't became read-only intentionally, it was just a limitation due to how runtime deprecation was implemented.

It was quite intentional, it was even documented as such.

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2024
mertcanaltin
mertcanaltin approved these changes Oct 26, 2024
View reviewed changes

@mertcanaltinmertcanaltin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LiviaMedeirosLiviaMedeiros mentioned this pull request Oct 26, 2024
Merged
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 28, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 7270f84 into nodejs:mainOct 28, 2024
@nodejs-github-bot

nodejs-github-bot commented Oct 28, 2024

Copy link
Copy Markdown
Collaborator

Landed in 7270f84

@aduh95
aduh95 deleted the writable-dirent-path branch October 28, 2024 11:02
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2024
@aduh95@RafaelGSS
fs: make dirent.path writable
f628fc4
PR-URL: #55547
Refs: #55538
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
RafaelGSS added a commit to RafaelGSS/node that referenced this pull request Nov 1, 2024
@RafaelGSS
2024-11-01, Version 23.2.0 (Current)
736f2f1
Notable changes:
doc:
* move typescript support to active development (Marco Ippolito) nodejs#55536
* add jazelly to collaborators (Jason Zhang) nodejs#55531
fs:
* (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) nodejs#55547
http:
* (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) nodejs#55586
module:
* (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) nodejs#55412
* (SEMVER-MINOR) add module.stripTypeScriptTypes (Marco Ippolito) nodejs#55282
PR-URL: TODO
@aduh95aduh95 mentioned this pull request Nov 6, 2024
Merged
aduh95 added a commit that referenced this pull request Nov 6, 2024
@aduh95
2024-11-07, Version 23.2.0 (Current)
69c6bf2
Notable changes:
crypto:
* update root certificates to NSS 3.104 (Richard Lau) #55681
doc:
* move typescript support to active development (Marco Ippolito) #55536
* add jazelly to collaborators (Jason Zhang) #55531
fs:
* (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) #55547
http:
* (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586
module:
* (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412
* (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) #55282
PR-URL: #55741
aduh95 added a commit that referenced this pull request Nov 9, 2024
@aduh95
2024-11-11, Version 23.2.0 (Current)
f2bac99
Notable changes:
crypto:
* update root certificates to NSS 3.104 (Richard Lau) #55681
doc:
* move typescript support to active development (Marco Ippolito) #55536
* add jazelly to collaborators (Jason Zhang) #55531
fs:
* (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) #55547
http:
* (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586
module:
* (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412
* (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) #55282
PR-URL: #55741
aduh95 added a commit that referenced this pull request Nov 11, 2024
@aduh95
2024-11-11, Version 23.2.0 (Current)
a83fbdb
Notable changes:
crypto:
* update root certificates to NSS 3.104 (Richard Lau) #55681
doc:
* move typescript support to active development (Marco Ippolito) #55536
* add jazelly to collaborators (Jason Zhang) #55531
fs:
* (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) #55547
http:
* (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586
module:
* (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412
* (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) #55282
PR-URL: #55741
aduh95 added a commit that referenced this pull request Nov 11, 2024
@aduh95
2024-11-11, Version 23.2.0 (Current)
c52c670
Notable changes:
crypto:
* update root certificates to NSS 3.104 (Richard Lau) #55681
doc:
* move typescript support to active development (Marco Ippolito) #55536
* add jazelly to collaborators (Jason Zhang) #55531
fs:
* (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) #55547
http:
* (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586
module:
* (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412
* (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) #55282
PR-URL: #55741
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@anonriganonriganonrig approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes
@LiviaMedeirosLiviaMedeirosLiviaMedeiros approved these changes
+1 more reviewer
@mertcanaltinmertcanaltinmertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.fsIssues and PRs related to the fs subsystem / file system.needs-ciPRs that need a full CI run.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@aduh95@nodejs-github-bot@mcollina@anonrig@RafaelGSS@mertcanaltin@atlowChemi@LiviaMedeiros