test_runner: pass `options` directly to `TestCoverage` by avivkeller · Pull Request #55578 · nodejs/node

avivkeller · 2024-10-28T23:00:22Z

This should make future modifications to the TestCoverage class simpler, as additional options don't need to be added to the constructor.

nodejs-github-bot · 2024-10-28T23:00:26Z

Review requested:

@nodejs/test_runner

codecov · 2024-10-29T03:20:47Z

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.32%. Comparing base (5633c62) to head (c982694).
Report is 200 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/test_runner/coverage.js	95.83%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #55578 +/- ##
==========================================
+ Coverage 87.93% 88.32% +0.39% 
==========================================
Files 654 654 Lines 187686 187658 -28 Branches 35819 36049 +230 ==========================================
+ Hits 165038 165746 +708 + Misses 15849 15125 -724 + Partials 6799 6787 -12

Files with missing lines	Coverage Δ
lib/internal/test_runner/coverage.js	`64.34% <95.83%> (-0.47%)`	⬇️

... and 98 files with indirect coverage changes

pmarchini

LGTM

nodejs-github-bot · 2024-10-29T10:40:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63335/

nodejs-github-bot · 2024-10-29T14:40:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63337/

avivkeller · 2024-10-29T21:00:33Z

CI is 💚 , can someone add the commit-queue label so once 48hrs pass this can land quickly and smoothly?

JakobJingleheimer · 2024-10-29T21:02:03Z

IIR, you can add it whenever, and once the wait time has elapsed, it will kick in automatically

avivkeller · 2024-10-29T21:11:41Z

IIR, you can add it whenever, and once the wait time has elapsed, it will kick in automatically

I can't, I'm not a collaborator. If I could, I would.

JakobJingleheimer · 2024-10-30T10:35:18Z

It looks like CI stalled after everything passed, and just didn't mark itself completed.

nodejs-github-bot · 2024-10-30T23:10:52Z

Commit Queue failed

- Loading data for nodejs/node/pull/55578
✔ Done loading data for nodejs/node/pull/55578
----------------------------------- PR info ------------------------------------
Title test_runner: pass `options` directly to `TestCoverage` (#55578)
Author Aviv Keller <redyetidev@gmail.com> (@RedYetiDev)
Branch RedYetiDev:options-testcoverage -> nodejs:main
Labels author ready, test_runner
Commits 1
- test_runner: pass `options` directly to `TestCoverage`
Committers 1
- RedYetiDev <38299977+RedYetiDev@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/55578
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/55578
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
--------------------------------------------------------------------------------
ℹ This PR was created on Mon, 28 Oct 2024 23:00:22 GMT
✔ Approvals: 1
✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/55578#pullrequestreview-2401251223
✘ This PR needs to wait 119 more hours to land (or 0 hours if there is one more approval)
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2024-10-29T14:40:07Z: https://ci.nodejs.org/job/node-test-pull-request/63337/
- Querying data for job/node-test-pull-request/63337/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/11603069194

avivkeller · 2024-10-30T23:12:39Z

The GitHub bot didn't count at @pmarchini's review to do a typo in the README. See #55625

avivkeller · 2024-11-01T14:00:27Z

Thanks @rluvaton! Now that this has two countable reviews, can someone add the commit-queue label?

nodejs-github-bot · 2024-11-01T14:20:20Z

Landed in 9b6cea6

PR-URL: #55578 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Raz Luvaton <rluvaton@gmail.com>

ruyadorno · 2024-11-27T06:39:15Z

This commit does not land cleanly on v22.x-staging and will need manual backport in case we want it in v22.x.

Backport blocked by #54705 (comment)

test_runner: pass options directly to TestCoverage
c982694

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Oct 28, 2024

pmarchini reviewed Oct 29, 2024
View reviewed changes

Comment threadlib/internal/test_runner/coverage.js

pmarchini approved these changes Oct 29, 2024
View reviewed changes

MoLow approved these changes Oct 29, 2024
View reviewed changes

avivkeller added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 29, 2024

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2024

pmarchini added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 29, 2024

JakobJingleheimer removed the needs-ci PRs that need a full CI run. label Oct 30, 2024

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 30, 2024

avivkeller requested a review from JakobJingleheimer October 31, 2024 12:39

avivkeller removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 31, 2024

rluvaton approved these changes Nov 1, 2024
View reviewed changes

rluvaton added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 1, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 1, 2024

nodejs-github-bot merged commit 9b6cea6 into nodejs:mainNov 1, 2024

RafaelGSS pushed a commit that referenced this pull request Nov 1, 2024
test_runner: pass options directly to TestCoverage
3234dc6
PR-URL: #55578 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Raz Luvaton <rluvaton@gmail.com>

aduh95 mentioned this pull request Nov 6, 2024
2024-11-11, Version 23.2.0 (Current) #55741
Merged

ruyadorno added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label Nov 27, 2024

Uh oh!

Uh oh!

Conversation

avivkeller commented Oct 28, 2024

Uh oh!

nodejs-github-bot commented Oct 28, 2024

Uh oh!

codecovBot commented Oct 29, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

pmarchini left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Oct 29, 2024

Uh oh!

nodejs-github-bot commented Oct 29, 2024

Uh oh!

avivkeller commented Oct 29, 2024

Uh oh!

JakobJingleheimer commented Oct 29, 2024

Uh oh!

avivkeller commented Oct 29, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JakobJingleheimer commented Oct 30, 2024

Uh oh!

nodejs-github-bot commented Oct 30, 2024

Uh oh!

avivkeller commented Oct 30, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

avivkeller commented Nov 1, 2024

Uh oh!

nodejs-github-bot commented Nov 1, 2024

Uh oh!

ruyadorno commented Nov 27, 2024• edited by aduh95 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecovBot commented Oct 29, 2024•
edited
Loading

avivkeller commented Oct 29, 2024•
edited
Loading

avivkeller commented Oct 30, 2024•
edited
Loading

ruyadorno commented Nov 27, 2024•
edited by aduh95
Loading