Skip to content

[v22.x backport] doc: consolidate history table of CustomEvent - #55805

Closed
geeksilva97 wants to merge 1 commit into
nodejs:v22.x-stagingfrom
geeksilva97:backport-fix-issue-55733
Closed

[v22.x backport] doc: consolidate history table of CustomEvent#55805
geeksilva97 wants to merge 1 commit into
nodejs:v22.x-stagingfrom
geeksilva97:backport-fix-issue-55733

Conversation

@geeksilva97

Copy link
Copy Markdown
Contributor

Backport of: #55758
Fixes: #55733
Refs: #55733

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Nov 10, 2024
@geeksilva97
geeksilva97 marked this pull request as ready for review November 10, 2024 02:15
@geeksilva97
geeksilva97force-pushed the backport-fix-issue-55733 branch from 38d031b to 256b1e2CompareNovember 10, 2024 02:46
@aduh95

Copy link
Copy Markdown
Contributor

The commit message should be the same as the one that landed on 23.x (355af0f), including the metadata (Reviewed-by, PR-URL, etc.). It should also have the same author and date.

PR-URL: nodejs#55758Fixes: nodejs#55733
Refs: nodejs#55733
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
@geeksilva97
geeksilva97force-pushed the backport-fix-issue-55733 branch from 256b1e2 to da5be81CompareNovember 11, 2024 02:29
@geeksilva97

Copy link
Copy Markdown
ContributorAuthor

The commit message should be the same as the one that landed on 23.x (355af0f), including the metadata (Reviewed-by, PR-URL, etc.). It should also have the same author and date.

Got it. It's fixed!

ruyadorno pushed a commit that referenced this pull request Nov 21, 2024
PR-URL: #55758
Backport-PR-URL: #55805Fixes: #55733
Refs: #55733
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
@ruyadorno

Copy link
Copy Markdown
Member

Landed in 9ffd2dd

@ruyadorno

Copy link
Copy Markdown
Member

vlw @geeksilva97! 👍

@geeksilva97

Copy link
Copy Markdown
ContributorAuthor

vlw @geeksilva97! 👍

Anytime 🇧🇷

@geeksilva97
geeksilva97 deleted the backport-fix-issue-55733 branch December 16, 2024 20:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.v22.xIssues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@geeksilva97@aduh95@ruyadorno@nodejs-github-bot