Skip to content

lib: remove unused file fetch_module - #55880

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:rm-fetch-module
Nov 18, 2024
Merged

lib: remove unused file fetch_module#55880
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:rm-fetch-module

Conversation

@targos

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-botnodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Nov 16, 2024

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI agrees

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov

codecovBot commented Nov 16, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.48%. Comparing base (b02cd41) to head (842d353).
Report is 79 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #55880 +/- ##
==========================================
+ Coverage 88.42% 88.48% +0.06% 
==========================================
Files 654 653 -1 Lines 187852 187551 -301 Branches 36134 36136 +2 ==========================================
- Hits 166102 165963 -139 + Misses 14989 14828 -161 + Partials 6761 6760 -1 

see 31 files with indirect coverage changes

@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 16, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 16, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@avivkelleravivkeller added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 16, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 16, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 18, 2024
@nodejs-github-bot
nodejs-github-bot merged commit a2edde4 into nodejs:mainNov 18, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in a2edde4

RafaelGSS pushed a commit that referenced this pull request Nov 18, 2024
PR-URL: #55880
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@ruyadorno

Copy link
Copy Markdown
Member

This commit does not land cleanly on v22.x-staging and will need manual backport in case we want it in v22.x.

@ruyadornoruyadorno added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label Nov 27, 2024
@aduh95aduh95 removed the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label May 19, 2025
aduh95 pushed a commit that referenced this pull request May 19, 2025
PR-URL: #55880
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@ghostghost mentioned this pull request Jun 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.esmIssues and PRs related to the ECMAScript Modules implementation.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

11 participants

@targos@nodejs-github-bot@ruyadorno@mcollina@lpinca@anonrig@JakobJingleheimer@aduh95@marco-ippolito@atlowChemi@avivkeller