Uh oh!
There was an error while loading. Please reload this page.
Create vee-eight-5.0 branch - #5592
Conversation
targos
commented
Mar 7, 2016
targos
commented
Mar 9, 2016
snapshot generation fails on armv8: https://ci.nodejs.org/job/node-test-commit-arm/2474/nodes=armv8-ubuntu1404/console |
V8 5.0 introduced a small modification for the unexpected end of input error.
497dea9 to
9f465dcComparetargos
commented
Mar 17, 2016
Updated to 5.0.71.19. |
bnoordhuis
commented
Mar 18, 2016
LGTM and sorry for the delay. Snapshotting on the armv8 bot still fails with a segmentation fault. I can probably figure out why if someone from @nodejs/build gives me access. |
indutny
commented
Mar 18, 2016
Rubber-stamp LGTM |
jbergstroem
commented
Mar 18, 2016
@bnoordhuis I'll be slightly afk today (saturday) but ping me on irc and tell me where you need access. I'll hook you up. |
jbergstroem
commented
Mar 21, 2016
@bnoordhuis ping re access |
bnoordhuis
commented
Mar 21, 2016
@jbergstroem Sorry, must've missed your previous reply. I'll ping you on IRC later today. |
targos
commented
Mar 26, 2016
I will be on a Greek island for the next two weeks and I don't think I'll have time to play with a computer, so anyone feel free to take over this PR ! |
ofrobots
commented
Mar 26, 2016
I can help with this. Enjoy your trip! @jbergstroem I will ping you on Monday to get access to an ARM8 machine to diagnose the snapshot issue. |
ofrobots
commented
Mar 28, 2016
I updated my copy of The snapshot generation segfault is gone (probably because of this fix). There is different failure on arm that I need to investigate. |
ofrobots
commented
Mar 28, 2016
Second CI run: https://ci.nodejs.org/job/node-test-commit/2717/. Failure seems to be a flake. |
trevnorris
commented
Mar 29, 2016
I just tried the build on the latest of this branch and am seeing the following: Can anyone else confirm that EDIT: nm me. Confused my branches. |
ofrobots
commented
Mar 29, 2016
@trevnorris A blank |
ofrobots
commented
Mar 29, 2016
Taking this PR over in #5945. |
Since install is per machine only, installation path should be stored in local machine instead of current user. The registry stores HKLM in different places for 32 and 64 bit applications, so the installer will not suggest the old path when upgrading from 32 to 64 bit version. Fixesnodejs#5592Fixesnodejs#25087 PR-URL: nodejs/node-v0.x-archive#25640 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> Reviewed-By: Bert Belder <bertbelder@gmail.com>
Since install is per machine only, installation path should be stored in local machine instead of current user. The registry stores HKLM in different places for 32 and 64 bit applications, so the installer will not suggest the old path when upgrading from 32 to 64 bit version. Fixesnodejs#5592Fixesnodejs#25087
Pull Request check-list
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Affected core subsystem(s)
deps
Description of change
Picked up latest commit of 5.0-lkgr.
There is only one test to update this time.
R= @bnoordhuis, @ofrobots
cc @nodejs/v8