Skip to content

doc: add create-release-action to process - #55993

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
RafaelGSS:mention-create-release-proposal
Dec 3, 2024
Merged

doc: add create-release-action to process#55993
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
RafaelGSS:mention-create-release-proposal

Conversation

@RafaelGSS

Copy link
Copy Markdown
Member

After #55690 it's time to suggest it's usage as a replacement of manual steps.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 25, 2024
@RafaelGSS
RafaelGSS requested a review from a teamNovember 25, 2024 15:39
@targos

Copy link
Copy Markdown
Member

https://github.com/nodejs/node/actions/workflows/create-release-proposal.yml

I'd make sure it succeeds at least once before recommending in in the documentation.

Comment threaddoc/contributing/releases.md Outdated
@RafaelGSS

RafaelGSS commented Nov 26, 2024

Copy link
Copy Markdown
MemberAuthor

https://github.com/nodejs/node/actions/workflows/create-release-proposal.yml

I'd make sure it succeeds at least once before recommending in in the documentation.

@ruyadorno will use it for next v22 release. Let's wait then.

Note, I have been using the action on my local fork and it was working ok https://github.com/RafaelGSS/node/actions/workflows/create-release-proposal.yml (the last run was an old state, so do not consider the run #24)

@ruyadorno

Copy link
Copy Markdown
Member

@ruyadorno will use it for next v22 release. Let's wait then.

It worked! 🥳 you can see the result here: #56040

Notably there are a few tweakings that we might still want to see if it can be improved, such as adding the correct attribution by using the handler of the user that triggered the action (if possible) and notable changes can probably also have a more streamlined workflow.

That said, this is amazing @RafaelGSS 🤩 I'm super excited to be finally seeing all this automation taking shape!

@RafaelGSS

Copy link
Copy Markdown
MemberAuthor

I will create a roadmap for this on nodejs/releasers repository so we can share any issues or improvement suggestions. Meanwhile, I think it's ok to land this after changing from UI to GH CLI, right?

@RafaelGSSRafaelGSS added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 27, 2024
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 1, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/55993
✔ Done loading data for nodejs/node/pull/55993
----------------------------------- PR info ------------------------------------
Title doc: add create-release-action to process (#55993)
Author Rafael Gonzaga <rafael.nunu@hotmail.com> (@RafaelGSS)
Branch RafaelGSS:mention-create-release-proposal -> nodejs:main
Labels doc, author ready, commit-queue-squash
Commits 2
- doc: add create-release-action to process
- fixup! doc: add create-release-action to process
Committers 1
- RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: https://github.com/nodejs/node/pull/55993
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/55993
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
--------------------------------------------------------------------------------
ℹ This PR was created on Mon, 25 Nov 2024 15:36:02 GMT
✔ Approvals: 1
✔ - Ruy Adorno (@ruyadorno) (TSC): https://github.com/nodejs/node/pull/55993#pullrequestreview-2465952345
✘ This PR needs to wait 19 more hours to land (or 0 hours if there is one more approval)
✔ Last GitHub CI successful
ℹ Green GitHub CI is sufficient
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/12108762220

@RafaelGSSRafaelGSS added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Dec 3, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 3, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 742ea1c into nodejs:mainDec 3, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 742ea1c

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@RafaelGSS@nodejs-github-bot@targos@ruyadorno@aduh95