Skip to content

[v22.x backport] module: add findPackageJSON util - #56074

Merged
aduh95 merged 2 commits into
nodejs:v22.x-stagingfrom
JakobJingleheimer:backport/add-findPackageJSON-util
Dec 10, 2024
Merged

[v22.x backport] module: add findPackageJSON util#56074
aduh95 merged 2 commits into
nodejs:v22.x-stagingfrom
JakobJingleheimer:backport/add-findPackageJSON-util

Conversation

@JakobJingleheimer

@JakobJingleheimerJakobJingleheimer commented Nov 29, 2024

Copy link
Copy Markdown
Member

PR-URL: #55412
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com

@nodejs-github-bot

nodejs-github-bot commented Nov 29, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-botnodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Nov 29, 2024
@aduh95

aduh95 commented Nov 29, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Can you also backport #55543 in the same PR please?

@JakobJingleheimer

JakobJingleheimer commented Nov 29, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Can you also backport #55543 in the same PR please?

Looks like the answer is yes 🙂

#55543 (comment)

@JakobJingleheimer

JakobJingleheimer commented Nov 29, 2024

Copy link
Copy Markdown
MemberAuthor

Can you also backport #55543 in the same PR please?

Well that was easy 😁

@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024
@nodejs-github-bot

nodejs-github-bot commented Nov 29, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63780/

@nodejs-github-bot

nodejs-github-bot commented Nov 29, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63794/

@nodejs-github-bot

nodejs-github-bot commented Nov 30, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63798/

@JakobJingleheimer

JakobJingleheimer commented Nov 30, 2024

Copy link
Copy Markdown
MemberAuthor

It looks like everything is green but coverage, which seems bogus: it passed on the original. To my knowledge, it already has full coverage (aside from #55822), so I'm not sure how to address this.

@JakobJingleheimerJakobJingleheimer mentioned this pull request Dec 7, 2024
Merged
@JakobJingleheimerJakobJingleheimer added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 10, 2024
JakobJingleheimerand others added 2 commits December 10, 2024 22:15
@JakobJingleheimer@aduh95
module: add findPackageJSON util
807f34f
PR-URL: nodejs#55412
Backport-PR-URL: nodejs#56074
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95
module: simplify findPackageJSON implementation
4f85047
PR-URL: nodejs#55543
Backport-PR-URL: nodejs#56074
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: nodejs#55412
@aduh95
aduh95force-pushed the backport/add-findPackageJSON-util branch from 3a67999 to 4f85047CompareDecember 10, 2024 21:21
@aduh95
aduh95 merged commit 4f85047 into nodejs:v22.x-stagingDec 10, 2024
@aduh95

aduh95 commented Dec 10, 2024

Copy link
Copy Markdown
Contributor

Landed in 552a182...4f85047

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes
@aduh95aduh95aduh95 approved these changes
@ruyadornoruyadornoAwaiting requested review from ruyadorno

Assignees

No one assigned

Labels

lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.v22.xIssues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JakobJingleheimer@nodejs-github-bot@aduh95@anonrig