Skip to content

deps: remove unused openssl files - #5619

Merged
bnoordhuis merged 1 commit into
nodejs:masterfrom
bnoordhuis:remove-unused-openssl-files
Mar 21, 2016
Merged

deps: remove unused openssl files#5619
bnoordhuis merged 1 commit into
nodejs:masterfrom
bnoordhuis:remove-unused-openssl-files

Conversation

@bnoordhuis

@bnoordhuisbnoordhuis commented Mar 9, 2016

Copy link
Copy Markdown
Member

@bnoordhuisbnoordhuis added the crypto Issues and PRs related to the crypto subsystem. label Mar 9, 2016
@indutny

indutny commented Mar 9, 2016

Copy link
Copy Markdown
Member

Do we want to document this?

LGTM

@mscdexmscdex added the openssl Issues and PRs related to the OpenSSL dependency. label Mar 9, 2016
@bnoordhuis

bnoordhuis commented Mar 9, 2016

Copy link
Copy Markdown
MemberAuthor

They're detritus from before we had a real process for upgrading openssl, if I understand your question right.

@rvagg

rvagg commented Mar 9, 2016

Copy link
Copy Markdown
Member

they don't come from openssl source?

@indutny

indutny commented Mar 9, 2016

Copy link
Copy Markdown
Member

Ah, ok then.

@rvagg

rvagg commented Mar 9, 2016

Copy link
Copy Markdown
Member

OK, I've moved dist-indexer to try opensslv.h. It's not a historically reliable file since it's pretty new but I'm using Makefile as a fallback.

nodejs/build@4030c77

So this change lgtm

@rvaggrvagg mentioned this pull request Mar 9, 2016
Closed
@shigeki

shigeki commented Mar 9, 2016

Copy link
Copy Markdown
Contributor

These files are also included in openssl-1.0.2g.tar.gz but not in git repo. They are generated by Configure and Makefile and written in .gitignore and they are not necessary for building node.
Do we use git repo for getting openssl source?
I think that it is better for us to obtain openssl sources from https://www.openssl.org/source/ instead of from git repo because pgp sign and hash are provided.

@jbergstroem

jbergstroem commented Mar 9, 2016

Copy link
Copy Markdown
Member

LGTM

1 similar comment
@jasnell

jasnell commented Mar 11, 2016

Copy link
Copy Markdown
Member

LGTM

@bnoordhuis
deps: remove unused openssl files
a76cb4d
Refs: nodejs#5615
PR-URL: nodejs#5619
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rod Vagg <rod@vagg.org>
@bnoordhuis
bnoordhuisforce-pushed the remove-unused-openssl-files branch from 0e8d5b1 to a76cb4dCompareMarch 21, 2016 12:26
@bnoordhuis
bnoordhuis deleted the remove-unused-openssl-files branch March 21, 2016 12:26
@bnoordhuis
bnoordhuis merged commit a76cb4d into nodejs:masterMar 21, 2016
@jasnell

jasnell commented Mar 21, 2016

Copy link
Copy Markdown
Member

@bnoordhuis ... if I'm not mistaken this should be done in v4 also, correct?

@Fishrock123Fishrock123 mentioned this pull request Mar 22, 2016
Merged
Fishrock123 pushed a commit that referenced this pull request Mar 22, 2016
@bnoordhuis@Fishrock123
deps: remove unused openssl files
ae24d05
Refs: #5615
PR-URL: #5619
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rod Vagg <rod@vagg.org>
@bnoordhuis

bnoordhuis commented Mar 23, 2016

Copy link
Copy Markdown
MemberAuthor

@jasnell Sorry, yes; forgot to add the label. I think the PR should apply cleanly.

MylesBorins pushed a commit that referenced this pull request Mar 30, 2016
@bnoordhuisMyles Borins
deps: remove unused openssl files
4fe88bc
Refs: #5615
PR-URL: #5619
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2016
@bnoordhuisMyles Borins
deps: remove unused openssl files
1d0e4a9
Refs: #5615
PR-URL: #5619
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rod Vagg <rod@vagg.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cryptoIssues and PRs related to the crypto subsystem.opensslIssues and PRs related to the OpenSSL dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@bnoordhuis@indutny@rvagg@shigeki@jbergstroem@jasnell@mscdex@MylesBorins