Skip to content

[v22.x backport] util: add sourcemap support to getCallSites - #56209

Closed
marco-ippolito wants to merge 1 commit into
nodejs:v22.x-stagingfrom
marco-ippolito:backport-util-callsite-sourcemap
Closed

[v22.x backport] util: add sourcemap support to getCallSites#56209
marco-ippolito wants to merge 1 commit into
nodejs:v22.x-stagingfrom
marco-ippolito:backport-util-callsite-sourcemap

Conversation

@marco-ippolito

@marco-ippolitomarco-ippolito commented Dec 10, 2024

Copy link
Copy Markdown
Member

PR-URL: #55589
Fixes: #55109
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Chengzhong Wu legendecas@gmail.com

@marco-ippolito
util: add sourcemap support to getCallSites
cf1e9ea
PR-URL: nodejs#55589Fixes: nodejs#55109
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@nodejs-github-bot

nodejs-github-bot commented Dec 10, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/typescript

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Dec 10, 2024
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 10, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2024
@nodejs-github-bot

nodejs-github-bot commented Dec 10, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63984/

marco-ippolito added a commit that referenced this pull request Dec 14, 2024
@marco-ippolito
util: add sourcemap support to getCallSites
2dd61ae
PR-URL: #55589
Backport-PR-URL: #56209Fixes: #55109
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@marco-ippolito

marco-ippolito commented Dec 14, 2024

Copy link
Copy Markdown
MemberAuthor

Landed in 2dd61ae

aduh95 pushed a commit that referenced this pull request Dec 18, 2024
@marco-ippolito@aduh95
util: add sourcemap support to getCallSites
5d92a5f
PR-URL: #55589
Backport-PR-URL: #56209Fixes: #55109
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
ruyadorno pushed a commit that referenced this pull request Jan 5, 2025
@marco-ippolito@ruyadorno
util: add sourcemap support to getCallSites
bcfe9c8
PR-URL: #55589
Backport-PR-URL: #56209Fixes: #55109
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharbljharbljharb approved these changes
@UlisesGasconUlisesGasconUlisesGascon approved these changes
@aduh95aduh95aduh95 approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes
+1 more reviewer
@mertcanaltinmertcanaltinmertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.utilIssues and PRs related to the built-in util module.v22.xIssues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@marco-ippolito@nodejs-github-bot@ljharb@UlisesGascon@aduh95@RafaelGSS@mertcanaltin