events: fix undefined passes to arrayClone

[origranot]

Fixes#56263

Another suggestion is to force developers to pass a string, else throw an ERR_INVALID_ARG_TYPE but this should consider a breaking change.

Looking forward for your feedback!

[anonrig]

Please add a test case

[origranot]

Please add a test case

Done 💯

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.54%. Comparing base (a50f3d5) to head (6b93137).
Report is 21 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #56264 +/- ##
==========================================
- Coverage 88.55% 88.54% -0.01% 
==========================================
Files 657 657 Lines 190243 190245 +2 Branches 36536 36542 +6 ==========================================
- Hits 168461 168457 -4 - Misses 14963 14968 +5 - Partials 6819 6820 +1 

Files with missing lines	Coverage Δ
lib/events.js	99.83% <100.00%> (+<0.01%)	⬆️

... and 25 files with indirect coverage changes

[lpinca]

This patch makes me wonder if 7a461ed was a good idea. I find it harder to read it now. I would revert 7a461ed and add the test included here.

[jakecastelli]

I am actually open to (prefer to) revert and add a test as well

[jazelly]

Had a private chat with @jakecastelli. I think it's better to revert this and add a test.

@origranot Would you like to raise a new PR to revert the commit and introduce a new commit to add the test?

[origranot]

Had a private chat with @jakecastelli. I think it's better to revert this and add a test.

@origranot Would you like to raise a new PR to revert the commit and introduce a new commit to add the test?

Yea, I am on it.

Thanks!

[origranot]

@jazelly
I opened a new PR here: #56282

[lpinca]

Closed in favor of #56282.