Uh oh!
There was an error while loading. Please reload this page.
deps: update openssl config - #5630
Closed
shigeki wants to merge 1 commit into
Closed
Conversation
OPENSSL_NO_SSL2 and OPENSSL_NO_WEAK_SSL_CIPHERS are defined in opensslconf.h
shigeki
commented
Mar 9, 2016
ContributorAuthor
Fishrock123
commented
Mar 9, 2016
Contributor
s/udpate/update/ :) |
shigekiforce-pushed
the
update_openssl_config
branch
from
March 9, 2016 17:14
a12afa6 to
d76834dCompareshigeki
commented
Mar 9, 2016
ContributorAuthor
@Fishrock123 Oops. Fixed typo. Thanks. |
shigekiforce-pushed
the
update_openssl_config
branch
from
March 10, 2016 01:18
d76834d to
ca8adf0Compareshigeki
commented
Mar 10, 2016
ContributorAuthor
CI in https://ci.nodejs.org/job/node-test-commit/2505/ is all green. |
shigeki
commented
Mar 10, 2016
ContributorAuthor
Strictly speaking, this fix corresponds to semver-major. As discussed in LTS on nodejs/Release#85, I would like to apply this to 5.x. |
jasnell
commented
Mar 11, 2016
Member
LGTM for master... Let's add it to the lts-agenda for Monday to discuss. |
shigeki
commented
Mar 15, 2016
ContributorAuthor
@indutny Could you review this PR? |
indutny
commented
Mar 15, 2016
Member
LGTM, if CI is green |
shigeki
commented
Mar 15, 2016
ContributorAuthor
@indutny Thanks. CI was submitted in https://ci.nodejs.org/job/node-test-pull-request/1927/. |
shigeki pushed a commit
that referenced
this pull request
Mar 15, 2016
OPENSSL_NO_SSL2 and OPENSSL_NO_WEAK_SSL_CIPHERS are defined in opensslconf.h Fixes: nodejs/Release#85 PR-URL: #5630 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
shigeki
commented
Mar 15, 2016
ContributorAuthor
CI is all green. Landed in 668fb17. Thanks. |
jasnell
commented
Mar 15, 2016
Member
shigeki
commented
Mar 15, 2016
ContributorAuthor
jasnell
commented
Mar 15, 2016
Member
Sounds good! :-) |
evanlucas pushed a commit
that referenced
this pull request
Mar 15, 2016
OPENSSL_NO_SSL2 and OPENSSL_NO_WEAK_SSL_CIPHERS are defined in opensslconf.h Fixes: nodejs/Release#85 PR-URL: #5630 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
Merged
rvagg pushed a commit
that referenced
this pull request
Mar 16, 2016
OPENSSL_NO_SSL2 and OPENSSL_NO_WEAK_SSL_CIPHERS are defined in opensslconf.h Fixes: nodejs/Release#85 PR-URL: #5630 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
MylesBorins
commented
Mar 17, 2016
Contributor
@shigeki is this pressing enough to roll into the next v4 release asap or should it have a bit of time to live on v5 first? |
shigeki
commented
Mar 18, 2016
ContributorAuthor
@thealphanerd This fix is a kind of regular procedures in upgrading openssl and has just a small risk. So it's already enough to roll to v4.x. |
MylesBorins pushed a commit
that referenced
this pull request
Mar 21, 2016
OPENSSL_NO_SSL2 and OPENSSL_NO_WEAK_SSL_CIPHERS are defined in opensslconf.h Fixes: nodejs/Release#85 PR-URL: #5630 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
MylesBorins pushed a commit
that referenced
this pull request
Mar 21, 2016
OPENSSL_NO_SSL2 and OPENSSL_NO_WEAK_SSL_CIPHERS are defined in opensslconf.h Fixes: nodejs/Release#85 PR-URL: #5630 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
deps: openssl
Description of change
deps/openssl/configwere not updated in the last upgrading. Two new defines of OPENSSL_NO_SSL2 and OPENSSL_NO_WEAK_SSL_CIPHERS are defined in opensslconf.h.This disables several ciphers included in EXPORT and LOW. They are also disabled in the default cipher list but I think that applying this to LTS should be discussed in LTS issue. I will open it.
CI is running on https://ci.nodejs.org/job/node-test-commit/2502/ but something Jenkins error was on MacOS. I will try it again.
R: @bnoordhuis