Skip to content

test: remove test-runner-watch-mode-complex flaky designation - #56470

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:remove/flaky-test-runner-watch-mode-complex
Jan 6, 2025
Merged

test: remove test-runner-watch-mode-complex flaky designation#56470
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:remove/flaky-test-runner-watch-mode-complex

Conversation

@lpinca

@lpincalpinca commented Jan 4, 2025

Copy link
Copy Markdown
Member

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 4, 2025
@codecov

codecovBot commented Jan 4, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.54%. Comparing base (b3f82fe) to head (0faa6ed).
Report is 26 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #56470 +/- ##
==========================================
+ Coverage 88.53% 88.54% +0.01% 
==========================================
Files 657 657 Lines 190719 190761 +42 Branches 36605 36611 +6 ==========================================
+ Hits 168848 168906 +58 - Misses 15040 15046 +6 + Partials 6831 6809 -22

see 53 files with indirect coverage changes

@aduh95aduh95 added dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 4, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 4, 2025
@nodejs-github-bot

nodejs-github-bot commented Jan 4, 2025•
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64344/ 💛

@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 5, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 6, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 984a472 into nodejs:mainJan 6, 2025
@nodejs-github-bot

nodejs-github-bot commented Jan 6, 2025

Copy link
Copy Markdown
Collaborator

Landed in 984a472

@lpinca
lpinca deleted the remove/flaky-test-runner-watch-mode-complex branch January 6, 2025 15:28
@RafaelGSSRafaelGSS mentioned this pull request May 1, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@jakecastellijakecastellijakecastelli approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lpinca@nodejs-github-bot@jasnell@jakecastelli@aduh95