tools: enable type checking within the internal/modules directory

[JakobJingleheimer]

This enables us to find the current type issues within the modules subsystem. There are quite a few.

Not sure if we should:

• merge this now and then fix (it could get annoying to see all the red, which is perhaps some dark UX to encourage people to fix them)
• fix all the type issues as part of this
• leave this open to the side whilst we merge in type fixes piecemeal, then merge this once they're all done

Perhaps we can eventually make this a CI check.

[nodejs-github-bot]

Review requested:

• @nodejs/loaders

[legendecas]

Type checking on JS files is not a nice experience -- to write types in JSDoc is sophisticated and making it enforced could lead to more sophisticated types and labor work in JSDoc to pass the check. I would prefer type stripping if enabling proper type check and a robust code base is what we eventually want.

node/lib/internal/modules/esm/utils.js

Lines 104 to 139 in 36c53c6

	/**
	* @callback ImportModuleDynamicallyCallback
	* @param {string} specifier
	* @param {ModuleWrap|ContextifyScript|Function|vm.Module} callbackReferrer
	* @param {Record<string, string>} attributes
	* @returns { Promise<void> }
	*/
	/**
	* @callback InitializeImportMetaCallback
	* @param {object} meta
	* @param {ModuleWrap|ContextifyScript|Function|vm.Module} callbackReferrer
	*/
	/**
	* @typedef {{
	* callbackReferrer: ModuleWrap|ContextifyScript|Function|vm.Module
	* initializeImportMeta? : InitializeImportMetaCallback,
	* importModuleDynamically? : ImportModuleDynamicallyCallback
	* }} ModuleRegistry
	*/
	/**
	* @type {WeakMap<symbol, ModuleRegistry>}
	*/
	constmoduleRegistries=newSafeWeakMap();
	/**
	* @typedef {ContextifyScript|Function|ModuleWrap|ContextifiedObject} Referrer
	* A referrer can be a Script Record, a Cyclic Module Record, or a Realm Record
	* as defined in https://tc39.es/ecma262/#sec-HostLoadImportedModule.
	*
	* In Node.js, a referrer is represented by a wrapper object of these records.
	* A referrer object has a field |host_defined_option_symbol| initialized with
	* a symbol.
	*/

[JakobJingleheimer]

I don't mind the jsdocs + type-checking (I use it in a couple projects). If we're open to type-stripping, that would be better! But a much more radical change I did not expect would get support.

[aduh95]

Let's use a commit message that makes it clear this is internal only, as is I thought you meant "in users' .ts files"

[github-actions]

This pull request has been marked as stale due to 210 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

[github-actions]

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.