Skip to content

src: add BaseObjectPtr nullptr operations - #56585

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:base-object-ptr-nullptr
Apr 10, 2025
Merged

src: add BaseObjectPtr nullptr operations#56585
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:base-object-ptr-nullptr

Conversation

@legendecas

@legendecaslegendecas commented Jan 13, 2025

Copy link
Copy Markdown
Member

Allow comparing a BaseObjectPtr or implicitly construct a
BaseObjectPtr with nullptr.

@nodejs-github-bot

nodejs-github-bot commented Jan 13, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 13, 2025
@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov

This comment was marked as outdated.

Sign in to view
jasnell
jasnell reviewed Jan 13, 2025
View reviewed changes
Comment threadsrc/node_contextify.cc Outdated
addaleax
addaleax reviewed Jan 13, 2025
View reviewed changes
Comment threadsrc/base_object-inl.h Outdated
Comment threadsrc/node_contextify.cc Outdated
@legendecas
legendecasforce-pushed the base-object-ptr-nullptr branch from 7d35dba to 06cb322CompareJanuary 22, 2025 11:07
@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@legendecas
src: add BaseObjectPtr nullptr operations
0d69bb8
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.
@legendecas
legendecasforce-pushed the base-object-ptr-nullptr branch from 06cb322 to 0d69bb8CompareJanuary 23, 2025 09:47
@legendecas

legendecas commented Jan 23, 2025

Copy link
Copy Markdown
MemberAuthor

Rebased to fix the failures that were on the main branch

@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jan 23, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64681/

@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 10, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 10, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 10, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66187/

@legendecaslegendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 10, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 10, 2025
@nodejs-github-bot
nodejs-github-bot merged commit f692878 into nodejs:mainApr 10, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 10, 2025

Copy link
Copy Markdown
Collaborator

Landed in f692878

@legendecas
legendecas deleted the base-object-ptr-nullptr branch April 10, 2025 16:43
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@legendecas@RafaelGSS
src: add BaseObjectPtr nullptr operations
9f691e8
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.
PR-URL: #56585
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@RafaelGSSRafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@legendecas@RafaelGSS
src: add BaseObjectPtr nullptr operations
3435001
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.
PR-URL: #56585
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@legendecas@aduh95
src: add BaseObjectPtr nullptr operations
1869b92
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.
PR-URL: #56585
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@legendecas@RafaelGSS
src: add BaseObjectPtr nullptr operations
50958c8
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.
PR-URL: #56585
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@legendecas@aduh95
src: add BaseObjectPtr nullptr operations
dd94236
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.
PR-URL: #56585
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@legendecas@aduh95
src: add BaseObjectPtr nullptr operations
8b3dd43
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.
PR-URL: #56585
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@legendecas@aduh95
src: add BaseObjectPtr nullptr operations
682d558
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.
PR-URL: #56585
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@github-actionsgithub-actionsBot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@legendecas@aduh95
src: add BaseObjectPtr nullptr operations
e00c1ec
Allow comparing a `BaseObjectPtr` or implicitly construct a
`BaseObjectPtr` with `nullptr`.
PR-URL: #56585
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@ghostghost mentioned this pull request Jun 8, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@legendecas@nodejs-github-bot@jasnell@addaleax