Skip to content

deps: update undici to 7.3.0 - #56624

Merged
nodejs-github-bot merged 1 commit into
mainfrom
actions/tools-update-undici
Feb 5, 2025
Merged

deps: update undici to 7.3.0#56624
nodejs-github-bot merged 1 commit into
mainfrom
actions/tools-update-undici

Conversation

@nodejs-github-bot

@nodejs-github-botnodejs-github-bot commented Jan 16, 2025

Copy link
Copy Markdown
Collaborator

This is an automated update of undici to 7.3.0.

@nodejs-github-botnodejs-github-bot added the dependencies Pull requests that update a dependency file. label Jan 16, 2025
@nodejs-github-bot

Copy link
Copy Markdown
CollaboratorAuthor

Review requested:

  • @nodejs/security-wg

@nodejs-github-botnodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 16, 2025
@codecov

codecovBot commented Jan 16, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.16%. Comparing base (2bd5694) to head (46eaec7).
Report is 23 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #56624 +/- ##
=======================================
Coverage 89.16% 89.16% =======================================
Files 665 665 Lines 192602 192602 Branches 37050 37060 +10 =======================================
+ Hits 171732 171743 +11 + Misses 13678 13674 -4 + Partials 7192 7185 -7 

see 25 files with indirect coverage changes

@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2025
@nodejs-github-bot

Copy link
Copy Markdown
CollaboratorAuthor

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawsonmhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2025
@nodejs-github-bot

Copy link
Copy Markdown
CollaboratorAuthor

@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 25, 2025
@nodejs-github-botnodejs-github-bot changed the title deps: update undici to 7.2.3deps: update undici to 7.3.0Jan 26, 2025
@nodejs-github-bot
nodejs-github-botforce-pushed the actions/tools-update-undici branch from 7f298c6 to 6ead0abCompareJanuary 26, 2025 00:32
@targos
targosforce-pushed the actions/tools-update-undici branch from 6ead0ab to f22b440CompareJanuary 29, 2025 09:32
@targos

Copy link
Copy Markdown
Member

Rebased to fix the test failure.

@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 29, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 29, 2025
@nodejs-github-bot

Copy link
Copy Markdown
CollaboratorAuthor

@nodejs-github-bot
nodejs-github-botforce-pushed the actions/tools-update-undici branch from f22b440 to 46eaec7CompareFebruary 2, 2025 00:33
@aduh95aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Feb 3, 2025

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 3, 2025
@nodejs-github-bot

Copy link
Copy Markdown
CollaboratorAuthor
Commit Queue failed
- Loading data for nodejs/node/pull/56624
✔ Done loading data for nodejs/node/pull/56624
----------------------------------- PR info ------------------------------------
Title deps: update undici to 7.3.0 (#56624)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch nodejs-github-bot:actions/tools-update-undici -> nodejs:main
Labels lib / src, author ready, needs-ci, dependencies, dont-land-on-v18.x, dont-land-on-v20.x, dont-land-on-v22.x, dont-land-on-v23.x
Commits 1
- deps: update undici to 7.3.0
Committers 1
- github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/56624
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/56624
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Thu, 16 Jan 2025 09:29:39 GMT
✔ Approvals: 6
✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/56624#pullrequestreview-2555930470
✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/56624#pullrequestreview-2560935233
✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/56624#pullrequestreview-2562848827
✔ - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/56624#pullrequestreview-2574204741
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/56624#pullrequestreview-2581374721
✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/56624#pullrequestreview-2589524963
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2025-01-29T15:16:59Z: https://ci.nodejs.org/job/node-test-pull-request/64822/
⚠ Commits were pushed after the last Full PR CI run:
⚠ - deps: update undici to 7.3.0
- Querying data for job/node-test-pull-request/64822/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/13111657431

@nodejs-github-bot

Copy link
Copy Markdown
CollaboratorAuthor

@nodejs-github-bot

Copy link
Copy Markdown
CollaboratorAuthor

@nodejs-github-bot

Copy link
Copy Markdown
CollaboratorAuthor

@nodejs-github-bot

Copy link
Copy Markdown
CollaboratorAuthor

@aduh95aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 5, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 5, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 9dee7b9 into mainFeb 5, 2025
@nodejs-github-bot

Copy link
Copy Markdown
CollaboratorAuthor

Landed in 9dee7b9

@nodejs-github-bot
nodejs-github-bot deleted the actions/tools-update-undici branch February 5, 2025 09:08
acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
PR-URL: nodejs#56624
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.dependenciesPull requests that update a dependency file.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@nodejs-github-bot@targos@jasnell@UlisesGascon@mhdawson@aduh95@RafaelGSS@marco-ippolito@richardlau