Skip to content

[v22.x backport] lib: ensure FORCE_COLOR forces color output in non-TTY environments - #56631

Merged
aduh95 merged 1 commit into
nodejs:v22.x-stagingfrom
pmarchini:backport/v22.x-force-color
Feb 3, 2025
Merged

[v22.x backport] lib: ensure FORCE_COLOR forces color output in non-TTY environments#56631
aduh95 merged 1 commit into
nodejs:v22.x-stagingfrom
pmarchini:backport/v22.x-force-color

Conversation

@pmarchini

@pmarchinipmarchini commented Jan 16, 2025

Copy link
Copy Markdown
Member

This PR should backport #55404, as a manual backport is required, and also addresses #52249 in this version

@nodejs-github-bot

nodejs-github-bot commented Jan 16, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Jan 16, 2025
@pmarchini
pmarchiniforce-pushed the backport/v22.x-force-color branch from 7ec5bd7 to 61c0540CompareJanuary 16, 2025 20:11
@pmarchinipmarchini changed the title Backport/v22.x force colorlib: ensure FORCE_COLOR forces color output in non-TTY environmentsJan 16, 2025
@pmarchini
pmarchini marked this pull request as ready for review January 16, 2025 20:12
cjihrig
cjihrig approved these changes Jan 16, 2025
View reviewed changes

@cjihrigcjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI passes.

@pmarchinipmarchini added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2025
@nodejs-github-bot

nodejs-github-bot commented Jan 17, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64543/

@richardlaurichardlau changed the title lib: ensure FORCE_COLOR forces color output in non-TTY environments[v22.x] lib: ensure FORCE_COLOR forces color output in non-TTY environmentsJan 17, 2025
@nodejs-github-bot

nodejs-github-bot commented Feb 3, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64945/

@aduh95aduh95 changed the title [v22.x] lib: ensure FORCE_COLOR forces color output in non-TTY environments[v22.x backport] lib: ensure FORCE_COLOR forces color output in non-TTY environmentsFeb 3, 2025
@pmarchini@aduh95
lib: ensure FORCE_COLOR forces color output in non-TTY environments
f0c556f
PR-URL: nodejs#55404
Backport-PR-URL: nodejs#56631
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95
aduh95force-pushed the backport/v22.x-force-color branch from 61c0540 to f0c556fCompareFebruary 3, 2025 12:12
@aduh95

aduh95 commented Feb 3, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Landed in 793981a

@aduh95
aduh95 merged commit f0c556f into nodejs:v22.x-stagingFeb 3, 2025
aduh95 pushed a commit that referenced this pull request Feb 4, 2025
@pmarchini@aduh95
lib: ensure FORCE_COLOR forces color output in non-TTY environments
793981a
PR-URL: #55404
Backport-PR-URL: #56631
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 6, 2025
@pmarchini@aduh95
lib: ensure FORCE_COLOR forces color output in non-TTY environments
d33eaf2
PR-URL: #55404
Backport-PR-URL: #56631
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@ruyadornoruyadornoAwaiting requested review from ruyadorno

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.utilIssues and PRs related to the built-in util module.v22.xIssues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pmarchini@nodejs-github-bot@aduh95@lpinca@cjihrig@BridgeAR