Uh oh!
There was an error while loading. Please reload this page.
doc: fix typos - #5678
Closed
watilde wants to merge 3 commits into
Closed
Conversation
zkat
commented
Mar 12, 2016
Contributor
LGTM! Hi, @watilde-san! 👋 |
evanlucas
commented
Mar 13, 2016
Contributor
LGTM CI: https://ci.nodejs.org/job/node-test-pull-request/1911/ (just because the addons docs are used for tests). Thanks!!! |
thefourtheye
commented
Mar 13, 2016
Contributor
The failed test is not related to this change. LGTM |
PR-URL: nodejs#5678 Reviewed-By: zkat - Kat Marchán <kzm@sykosomatic.org> Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: nodejs#5678 Reviewed-By: zkat - Kat Marchán <kzm@sykosomatic.org> Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: nodejs#5678 Reviewed-By: zkat - Kat Marchán <kzm@sykosomatic.org> Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
watilde
commented
Mar 14, 2016
MemberAuthor
Okey rebased and re-wrote commit messages :) |
cjihrig
commented
Mar 14, 2016
Contributor
LGTM |
1 similar comment
jasnell
commented
Mar 14, 2016
Member
LGTM |
jasnell pushed a commit
that referenced
this pull request
Mar 14, 2016
PR-URL: #5678 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit
that referenced
this pull request
Mar 14, 2016
PR-URL: #5678 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit
that referenced
this pull request
Mar 14, 2016
PR-URL: #5678 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
commented
Mar 14, 2016
Member
evanlucas pushed a commit
that referenced
this pull request
Mar 14, 2016
PR-URL: #5678 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit
that referenced
this pull request
Mar 14, 2016
PR-URL: #5678 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit
that referenced
this pull request
Mar 14, 2016
PR-URL: #5678 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Fishrock123
commented
Mar 14, 2016
Contributor
@watilde First commits I see! Welcome! 👏 :D |
rvagg pushed a commit
that referenced
this pull request
Mar 16, 2016
PR-URL: #5678 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit
that referenced
this pull request
Mar 16, 2016
PR-URL: #5678 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit
that referenced
this pull request
Mar 16, 2016
PR-URL: #5678 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
commented
Mar 17, 2016
Contributor
the only commit of the bunch that applied to v4.x is 23df9d9 Adding both the land-on and dont-land tags |
MylesBorins pushed a commit
that referenced
this pull request
Mar 17, 2016
PR-URL: #5678 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Mar 21, 2016
PR-URL: #5678 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Mar 21, 2016
PR-URL: #5678 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Affected core subsystem(s)
fs, dgram, addons
Description of change
addons:
dgram:
fs: