build: add skip_apidoc_files and include QUIC by RafaelGSS · Pull Request #56941 · nodejs/node

RafaelGSS · 2025-02-06T17:27:17Z

As we have discussed in TSC meeting

cc: @nodejs/tsc

codecov · 2025-02-06T18:47:48Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.11%. Comparing base (fc7682c) to head (db302e5).
Report is 409 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #56941 +/- ##
=======================================
Coverage 89.11% 89.11% =======================================
Files 665 665 Lines 193203 193203 Branches 37217 37214 -3 =======================================
+ Hits 172165 172177 +12 - Misses 13767 13769 +2 + Partials 7271 7257 -14

Files with missing lines	Coverage Δ
src/node_options.cc	`87.97% <ø> (ø)`

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mhdawson

LGTM after @aduh95 suggestion is incorporated.

targos · 2025-02-11T14:05:32Z

It's still not quite in the correct order

nodejs-github-bot · 2025-02-12T19:10:03Z

CI: https://ci.nodejs.org/job/node-test-pull-request/65154/

mhdawson · 2025-02-13T23:37:35Z

@RafaelGSS can you rebase?

nodejs-github-bot · 2025-02-17T21:11:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/65280/

nodejs-github-bot · 2025-02-18T03:04:28Z

Commit Queue failed

- Loading data for nodejs/node/pull/56941
✔ Done loading data for nodejs/node/pull/56941
----------------------------------- PR info ------------------------------------
Title build: add skip_apidoc_files and include QUIC (#56941)
Author Rafael Gonzaga <rafael.nunu@hotmail.com> (@RafaelGSS)
Branch RafaelGSS:hide-quic-documentation -> nodejs:main
Labels build, needs-ci
Commits 4
- build: add skip_apidoc_files and include QUIC
- fixup! build: add skip_apidoc_files and include QUIC
- fixup! fixup! build: add skip_apidoc_files and include QUIC
- fixup! fixup! fixup! build: add skip_apidoc_files and include QUIC
Committers 1
- RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: https://github.com/nodejs/node/pull/56941
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/56941
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
--------------------------------------------------------------------------------
⚠ Commits were pushed since the last approving review:
⚠ - build: add skip_apidoc_files and include QUIC
⚠ - fixup! build: add skip_apidoc_files and include QUIC
⚠ - fixup! fixup! build: add skip_apidoc_files and include QUIC
⚠ - fixup! fixup! fixup! build: add skip_apidoc_files and include QUIC
ℹ This PR was created on Thu, 06 Feb 2025 17:27:17 GMT
✔ Approvals: 2
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/56941#pullrequestreview-2600564603
✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/56941#pullrequestreview-2607299515
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2025-02-17T21:11:35Z: https://ci.nodejs.org/job/node-test-pull-request/65280/
- Querying data for job/node-test-pull-request/65280/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/13382384552

PR-URL: #56941 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

jasnell · 2025-02-18T03:23:58Z

Landed in 0a4572d

PR-URL: nodejs#56941 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

PR-URL: #56941 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

RafaelGSS · 2025-04-11T20:15:05Z

This commit didn't land cleanly on v22.x-staging. It requires a manual backport, so I'm adding a backport-requested label.

RafaelGSS requested a review from jasnell February 6, 2025 17:27

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Feb 6, 2025

jasnell approved these changes Feb 7, 2025
View reviewed changes

richardlau reviewed Feb 7, 2025
View reviewed changes

Comment threadtest/parallel/test-cli-node-options-docs.js Outdated

aduh95 reviewed Feb 10, 2025
View reviewed changes

Comment threaddoc/contributing/internal-api.md Outdated

mhdawson approved these changes Feb 10, 2025
View reviewed changes

RafaelGSS force-pushed the hide-quic-documentation branch from 200b03f to 295289fCompare February 11, 2025 14:17

RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 12, 2025

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 12, 2025

RafaelGSS added 4 commits February 14, 2025 12:10

build: add skip_apidoc_files and include QUIC
13d199d

fixup! build: add skip_apidoc_files and include QUIC
585a35d

fixup! fixup! build: add skip_apidoc_files and include QUIC
85e4ab4

fixup! fixup! fixup! build: add skip_apidoc_files and include QUIC
db302e5

RafaelGSS force-pushed the hide-quic-documentation branch from 295289f to db302e5Compare February 14, 2025 15:10

RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 17, 2025

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 17, 2025

RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 18, 2025

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 18, 2025

jasnell pushed a commit that referenced this pull request Feb 18, 2025
build: add skip_apidoc_files and include QUIC
0a4572d
PR-URL: #56941 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

This comment was marked as duplicate.
Sign in to view

jasnell closed this Feb 18, 2025

acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
build: add skip_apidoc_files and include QUIC
40719ff
PR-URL: nodejs#56941 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

targos pushed a commit that referenced this pull request Feb 24, 2025
build: add skip_apidoc_files and include QUIC
922ea2f
PR-URL: #56941 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

github-actionsBot mentioned this pull request Feb 25, 2025
2025-02-26, Version 23.9.0 (Current) #57207
Merged

targos pushed a commit that referenced this pull request Feb 25, 2025
build: add skip_apidoc_files and include QUIC
fec2d50
PR-URL: #56941 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

juanarbol mentioned this pull request Mar 3, 2025
The QUIC link is broken #57252
Closed

RafaelGSS mentioned this pull request Apr 8, 2025
v22.x-staging cherry-pick status #57799
Closed

RafaelGSS added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label Apr 11, 2025

pimterry mentioned this pull request Jul 25, 2026
build, doc: move to redesign #62045
Open

Navigation Menu

Uh oh!

Uh oh!

build: add skip_apidoc_files and include QUIC - #56941

build: add skip_apidoc_files and include QUIC#56941
RafaelGSS wants to merge 4 commits into
nodejs:mainfrom
RafaelGSS:hide-quic-documentation

RafaelGSS commented Feb 6, 2025•
edited
Loading

Uh oh!

codecovBot commented Feb 6, 2025•
edited
Loading

Uh oh!

Uh oh!

Uh oh!

mhdawson left a comment

Uh oh!

targos commented Feb 11, 2025

Uh oh!

nodejs-github-bot commented Feb 12, 2025

Uh oh!

mhdawson commented Feb 13, 2025

Uh oh!

nodejs-github-bot commented Feb 17, 2025

Uh oh!

nodejs-github-bot commented Feb 18, 2025

Uh oh!

jasnell commented Feb 18, 2025

Uh oh!

This comment was marked as duplicate.

RafaelGSS commented Apr 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Uh oh!

Conversation

RafaelGSS commented Feb 6, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecovBot commented Feb 6, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

targos commented Feb 11, 2025

Uh oh!

nodejs-github-bot commented Feb 12, 2025

Uh oh!

mhdawson commented Feb 13, 2025

Uh oh!

nodejs-github-bot commented Feb 17, 2025

Uh oh!

nodejs-github-bot commented Feb 18, 2025

Uh oh!

jasnell commented Feb 18, 2025

Uh oh!

This comment was marked as duplicate.

RafaelGSS commented Apr 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

RafaelGSS commented Feb 6, 2025•
edited
Loading

codecovBot commented Feb 6, 2025•
edited
Loading