Skip to content

test: improve test description - #56943

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jakecastelli:test-fix-pipeline-typo
Feb 9, 2025
Merged

test: improve test description#56943
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jakecastelli:test-fix-pipeline-typo

Conversation

@jakecastelli

@jakecastellijakecastelli commented Feb 6, 2025

Copy link
Copy Markdown
Member

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 6, 2025
@codecov

codecovBot commented Feb 6, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.15%. Comparing base (4355b3f) to head (e5b3fa8).
Report is 29 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #56943 +/- ##
=======================================
Coverage 89.14% 89.15% =======================================
Files 665 665 Lines 192846 192846 Branches 37147 37147 =======================================
+ Hits 171916 171929 +13 + Misses 13696 13694 -2 + Partials 7234 7223 -11

see 22 files with indirect coverage changes

@nodejs-github-bot

nodejs-github-bot commented Feb 7, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65043/

@jasnelljasnell added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 7, 2025
@github-actions

github-actionsBot commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

@nodejs-github-bot

nodejs-github-bot commented Feb 7, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65044/

@jakecastellijakecastelli added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 9, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 9, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 51ded6e into nodejs:mainFeb 9, 2025
@nodejs-github-bot

nodejs-github-bot commented Feb 9, 2025

Copy link
Copy Markdown
Collaborator

Landed in 51ded6e

@targostargos added dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Feb 10, 2025
acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
@jakecastelli@acidiney
test: improve test description
722e544
PR-URL: nodejs#56943
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request May 1, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@jazellyjazellyjazelly approved these changes
@pmarchinipmarchinipmarchini approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jakecastelli@nodejs-github-bot@jasnell@jazelly@pmarchini@targos