Uh oh!
There was an error while loading. Please reload this page.
doc: update testing documentation - #56953
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #56953 +/- ##
==========================================
- Coverage 89.15% 89.10% -0.06%
==========================================
Files 665 665 Lines 192846 193206 +360 Branches 37145 37217 +72 ==========================================
+ Hits 171926 172150 +224 - Misses 13696 13760 +64 - Partials 7224 7296 +72 |
nodejs-github-bot
commented
Feb 13, 2025
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/56953 ✔ Done loading data for nodejs/node/pull/56953 ----------------------------------- PR info ------------------------------------ Title doc: update testing documentation (#56953) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch Aditi-1400:test-doc-update -> nodejs:main Labels test, needs-ci Commits 1 - doc: update testing documentation Committers 1 - Aditi <aditisingh1400@gmail.com> PR-URL: https://github.com/nodejs/node/pull/56953 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56953 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 07 Feb 2025 20:42:22 GMT ✔ Approvals: 1 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/56953#pullrequestreview-2602840643 ✘ This PR needs to wait 29 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13311410448 |
richardlau
approved these changes
Feb 13, 2025
nodejs-github-bot
commented
Feb 13, 2025
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/56953 ✔ Done loading data for nodejs/node/pull/56953 ----------------------------------- PR info ------------------------------------ Title doc: update testing documentation (#56953) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch Aditi-1400:test-doc-update -> nodejs:main Labels test, needs-ci Commits 1 - doc: update testing documentation Committers 1 - Aditi <aditisingh1400@gmail.com> PR-URL: https://github.com/nodejs/node/pull/56953 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56953 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 07 Feb 2025 20:42:22 GMT ✔ Approvals: 2 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/56953#pullrequestreview-2602840643 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/56953#pullrequestreview-2615467845 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13311572887 |
aduh95
reviewed
Feb 15, 2025
Uh oh!
There was an error while loading. Please reload this page.
aduh95
commented
Feb 15, 2025
Contributor
Landed in 794f35f |
targos pushed a commit
that referenced
this pull request
Feb 17, 2025
PR-URL: #56953 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
acidiney pushed a commit
to acidiney/node
that referenced
this pull request
Feb 23, 2025
PR-URL: nodejs#56953 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95 pushed a commit
that referenced
this pull request
Apr 2, 2025
PR-URL: #56953 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95 pushed a commit
that referenced
this pull request
Apr 3, 2025
PR-URL: #56953 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
RafaelGSS pushed a commit
that referenced
this pull request
Apr 16, 2025
PR-URL: #56953 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
RafaelGSS pushed a commit
that referenced
this pull request
Apr 17, 2025
PR-URL: #56953 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
marco-ippolito pushed a commit
that referenced
this pull request
Aug 18, 2025
PR-URL: #56953 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
marco-ippolito pushed a commit
that referenced
this pull request
Aug 20, 2025
PR-URL: #56953 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
marco-ippolito pushed a commit
that referenced
this pull request
Aug 25, 2025
PR-URL: #56953 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
marco-ippolito pushed a commit
that referenced
this pull request
Aug 25, 2025
PR-URL: #56953 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
marco-ippolito pushed a commit
that referenced
this pull request
Aug 27, 2025
PR-URL: #56953 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update improves the test/common/README.md file by explaining why the common module is essential when writing tests.
I became curious about its importance while working on PR #56942, and @joyeecheung kindly provided the additional context that was missing from the documentation. :)