Uh oh!
There was an error while loading. Please reload this page.
build: fix GN build of uv - #56955
Merged
Merged
Conversation
nodejs-github-bot
commented
Feb 8, 2025
Collaborator
Review requested:
|
jasnell
approved these changes
Feb 8, 2025
anonrig
approved these changes
Feb 8, 2025
anonrig
commented
Feb 8, 2025
Member
Can we have a non-blocking GitHub workflow for GN? |
nodejs-github-bot
commented
Feb 8, 2025
Collaborator
lpinca
approved these changes
Feb 8, 2025
juanarbol
approved these changes
Feb 10, 2025
nodejs-github-bot
commented
Feb 10, 2025
Collaborator
nodejs-github-bot
commented
Feb 10, 2025
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/56955 ✔ Done loading data for nodejs/node/pull/56955 ----------------------------------- PR info ------------------------------------ Title build: fix GN build of uv (#56955) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch zcbenz:gn-build-uv -> nodejs:main Labels libuv, author ready, needs-ci Commits 1 - build: fix GN build of uv Committers 1 - Cheng <git@zcbenz.com> PR-URL: https://github.com/nodejs/node/pull/56955 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56955 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 08 Feb 2025 06:50:20 GMT ✔ Approvals: 4 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/56955#pullrequestreview-2603944582 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/56955#pullrequestreview-2604005726 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/56955#pullrequestreview-2604014419 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/56955#pullrequestreview-2606544820 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2025-02-10T16:52:04Z: https://ci.nodejs.org/job/node-test-pull-request/65126/ - Querying data for job/node-test-pull-request/65126/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13249696682 |
nodejs-github-bot
commented
Feb 11, 2025
Collaborator
nodejs-github-bot
commented
Feb 12, 2025
Collaborator
Landed in b07ff55 |
targos pushed a commit
that referenced
this pull request
Feb 17, 2025
PR-URL: #56955 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
acidiney pushed a commit
to acidiney/node
that referenced
this pull request
Feb 23, 2025
PR-URL: nodejs#56955 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Apr 2, 2025
PR-URL: #56955 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Apr 3, 2025
PR-URL: #56955 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
Apr 16, 2025
PR-URL: #56955 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
Apr 17, 2025
PR-URL: #56955 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which was broken after 756a242.