Skip to content

src: improve error handling in multiple files - #56962

Closed
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/improve-errorhandling-multiple-files
Closed

src: improve error handling in multiple files#56962
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/improve-errorhandling-multiple-files

Conversation

@jasnell

@jasnelljasnell commented Feb 8, 2025

Copy link
Copy Markdown
Member

Replace multiple uses of ToLocalChecked

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Feb 8, 2025
anonrig
anonrig approved these changes Feb 8, 2025
View reviewed changes
Comment threadsrc/node_report_module.cc Outdated

@anonriganonrigFeb 8, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this Pr, but we should definitely rewrite this function to avoid calling std::ostringstream

@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 8, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov

This comment was marked as outdated.

Sign in to view
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 8, 2025
@nodejs-github-bot

This comment was marked as duplicate.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
legendecas
legendecas approved these changes Feb 11, 2025
View reviewed changes
Comment threadsrc/node_process_object.cc Outdated
Comment threadsrc/node_process_object.cc Outdated
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
jasnellforce-pushed the jasnell/improve-errorhandling-multiple-files branch from ff2275d to 23cc2e1CompareFebruary 15, 2025 16:17
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
jasnellforce-pushed the jasnell/improve-errorhandling-multiple-files branch from 23cc2e1 to a550be2CompareFebruary 15, 2025 19:55
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell

jasnell commented Feb 16, 2025

Copy link
Copy Markdown
MemberAuthor

Blocked from landing by persistent windows CI issues. @nodejs/build @nodejs/platform-windows ... PR is otherwise ready to go.

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Feb 17, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65277/

jasnell added a commit that referenced this pull request Feb 17, 2025
@jasnell
src: improve error handling in multiple files
11e7535
PR-URL: #56962
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@jasnell

jasnell commented Feb 17, 2025

Copy link
Copy Markdown
MemberAuthor

Landed in 11e7535

@jasnelljasnell closed this Feb 17, 2025
acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
@jasnell@acidiney
src: improve error handling in multiple files
a3828ac
PR-URL: nodejs#56962
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos pushed a commit that referenced this pull request Feb 24, 2025
@jasnell@targos
src: improve error handling in multiple files
899890b
PR-URL: #56962
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Feb 25, 2025
Merged
targos pushed a commit that referenced this pull request Feb 25, 2025
@jasnell@targos
src: improve error handling in multiple files
5414eb4
PR-URL: #56962
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Apr 8, 2025
Closed
@RafaelGSSRafaelGSS added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label Apr 11, 2025
@RafaelGSS

RafaelGSS commented Apr 11, 2025

Copy link
Copy Markdown
Member

This commit didn't land cleanly on v22.x-staging. It requires a manual backport, so I'm adding a backport-requested label.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes
@legendecaslegendecaslegendecas approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.backport-requested-v22.xPRs awaiting manual backport to the v22.x-staging branch.c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jasnell@nodejs-github-bot@RafaelGSS@anonrig@legendecas