Skip to content

src: improve error handling in string_bytes/decoder - #56978

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jasnell:jasnell/string_bytes_errorhandling
Feb 11, 2025
Merged

src: improve error handling in string_bytes/decoder#56978
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jasnell:jasnell/string_bytes_errorhandling

Conversation

@jasnell

@jasnelljasnell commented Feb 9, 2025

Copy link
Copy Markdown
Member

Replace ToLocalChecked uses

@nodejs-github-botnodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 9, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov

codecovBot commented Feb 9, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.12%. Comparing base (d1f8ccb) to head (d970140).
Report is 23 commits behind head on main.

Files with missing linesPatch %Lines
src/string_bytes.cc85.71%0 Missing and 2 partials ⚠️
src/string_decoder.cc88.88%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #56978 +/- ##
==========================================
- Coverage 89.13% 89.12% -0.02% 
==========================================
Files 665 665 Lines 193167 193170 +3 Branches 37190 37183 -7 ==========================================
- Hits 172185 172165 -20 - Misses 13731 13732 +1 - Partials 7251 7273 +22
Files with missing linesCoverage Δ
src/string_decoder.cc91.75% <88.88%> (+0.12%)⬆️
src/string_bytes.cc68.43% <85.71%> (ø)

... and 22 files with indirect coverage changes

@anonriganonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 9, 2025
@nodejs-github-bot

nodejs-github-bot commented Feb 9, 2025•
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65104/ 💛

@jasnelljasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 10, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 11, 2025
@nodejs-github-bot
nodejs-github-bot merged commit cbedcd1 into nodejs:mainFeb 11, 2025
@nodejs-github-bot

nodejs-github-bot commented Feb 11, 2025

Copy link
Copy Markdown
Collaborator

Landed in cbedcd1

targos pushed a commit that referenced this pull request Feb 17, 2025
@jasnell@targos
src: improve error handling in string_bytes/decoder
41f444f
PR-URL: #56978
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
@jasnell@acidiney
src: improve error handling in string_bytes/decoder
40f27a0
PR-URL: nodejs#56978
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Feb 25, 2025
Merged
aduh95 pushed a commit that referenced this pull request Apr 2, 2025
@jasnell@aduh95
src: improve error handling in string_bytes/decoder
1cabad1
PR-URL: #56978
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 3, 2025
@jasnell@aduh95
src: improve error handling in string_bytes/decoder
a65722f
PR-URL: #56978
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@aduh95aduh95 mentioned this pull request Apr 11, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
@jasnell@RafaelGSS
src: improve error handling in string_bytes/decoder
61bb868
PR-URL: #56978
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 17, 2025
@jasnell@RafaelGSS
src: improve error handling in string_bytes/decoder
50f164e
PR-URL: #56978
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes
@legendecaslegendecaslegendecas approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.bufferIssues and PRs related to the buffer subsystem.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jasnell@nodejs-github-bot@anonrig@legendecas