Uh oh!
There was an error while loading. Please reload this page.
tools: add support for import source syntax in linter - #56992
Merged
Conversation
legendecas
approved these changes
Feb 11, 2025
targos
approved these changes
Feb 11, 2025
nodejs-github-bot
commented
Feb 12, 2025
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/56992 ✔ Done loading data for nodejs/node/pull/56992 ----------------------------------- PR info ------------------------------------ Title tools: add support for `import source` syntax in linter (#56992) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:source-import-lint -> nodejs:main Labels tools, author ready Commits 1 - tools: add support for `import source` syntax in linter Committers 1 - Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/56992 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56992 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 10 Feb 2025 15:01:43 GMT ✔ Approvals: 2 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/56992#pullrequestreview-2607474292 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/56992#pullrequestreview-2608054594 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 56992 From https://github.com/nodejs/node * branch refs/pull/56992/merge -> FETCH_HEAD ✔ Fetched commits as e7626dc70dbd..50a20ea40d52 -------------------------------------------------------------------------------- Auto-merging tools/eslint/package-lock.json CONFLICT (content): Merge conflict in tools/eslint/package-lock.json Auto-merging tools/eslint/package.json CONFLICT (content): Merge conflict in tools/eslint/package.json error: could not apply 50a20ea40d... tools: add support for `import source` syntax in linter hint: After resolving the conflicts, mark them with hint: "git add/rm <pathspec>", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort". hint: Disable this message with "git config set advice.mergeConflict false" ✘ Failed to apply patcheshttps://github.com/nodejs/node/actions/runs/13288558054 |
aduh95force-pushed
the
source-import-lint
branch
from
February 12, 2025 16:37
50a20ea to
1ede719Comparetargos
approved these changes
Feb 12, 2025
lpinca
approved these changes
Feb 12, 2025
nodejs-github-bot
commented
Feb 12, 2025
Collaborator
Landed in a7f648c |
targos pushed a commit
that referenced
this pull request
Feb 17, 2025
PR-URL: #56992 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
acidiney pushed a commit
to acidiney/node
that referenced
this pull request
Feb 23, 2025
PR-URL: nodejs#56992 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 added a commit
that referenced
this pull request
Apr 2, 2025
PR-URL: #56992 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 added a commit
that referenced
this pull request
Apr 3, 2025
PR-URL: #56992 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
Apr 16, 2025
PR-URL: #56992 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
Apr 17, 2025
PR-URL: #56992 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's going to be useful for #56919, IMO it makes sense to put it in a separate PR to avoid backporting issues.