Skip to content

fs: handle UV_ENOTDIR in is_uv_error_except_no_entry - #56996

Closed
juanarbol wants to merge 1 commit into
nodejs:mainfrom
juanarbol:juan/statsync-no-throw
Closed

fs: handle UV_ENOTDIR in is_uv_error_except_no_entry#56996
juanarbol wants to merge 1 commit into
nodejs:mainfrom
juanarbol:juan/statsync-no-throw

Conversation

@juanarbol

@juanarboljuanarbol commented Feb 10, 2025

Copy link
Copy Markdown
Member

Fixes: #56993

@juanarboljuanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 10, 2025
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Feb 10, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 10, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov

codecovBot commented Feb 10, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.10%. Comparing base (85f5a6c) to head (2397ca2).
Report is 18 commits behind head on main.

Files with missing linesPatch %Lines
src/node_file.cc80.00%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #56996 +/- ##
==========================================
- Coverage 89.11% 89.10% -0.01% 
==========================================
Files 665 665 Lines 193193 193196 +3 Branches 37212 37209 -3 ==========================================
- Hits 172158 172151 -7 + Misses 13775 13772 -3 - Partials 7260 7273 +13
Files with missing linesCoverage Δ
src/node_file.cc76.92% <80.00%> (+0.02%)⬆️

... and 23 files with indirect coverage changes

addaleax
addaleax requested changes Feb 11, 2025
View reviewed changes
Comment threadsrc/node_file.cc Outdated
@juanarbol
juanarbolforce-pushed the juan/statsync-no-throw branch from 4a62a75 to f2ef348CompareFebruary 11, 2025 20:16
@juanarbol

juanarbol commented Feb 11, 2025

Copy link
Copy Markdown
MemberAuthor

cc// @Ceres6

@juanarbol
juanarbolforce-pushed the juan/statsync-no-throw branch from f2ef348 to 985b3a3CompareFebruary 12, 2025 20:44
@juanarboljuanarbol added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Feb 12, 2025
@juanarbol
fs: handle UV_ENOTDIR in fs.statSync with throwIfNoEntry provided
2397ca2
Fixes: nodejs#56993
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
@juanarbol
juanarbolforce-pushed the juan/statsync-no-throw branch from 985b3a3 to 2397ca2CompareFebruary 12, 2025 20:48
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Feb 13, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65193/

@juanarboljuanarbol added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 14, 2025
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 14, 2025
@nodejs-github-bot

nodejs-github-bot commented Feb 14, 2025

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/56996
✔ Done loading data for nodejs/node/pull/56996
----------------------------------- PR info ------------------------------------
Title fs: handle UV_ENOTDIR in `is_uv_error_except_no_entry` (#56996)
Author Juan José <soyjuanarbol@gmail.com> (@juanarbol)
Branch juanarbol:juan/statsync-no-throw -> nodejs:main
Labels c++, fs, author ready, needs-ci
Commits 1
- fs: handle UV_ENOTDIR in `fs.statSync` with `throwIfNoEntry` provided
Committers 1
- Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/56996
Fixes: https://github.com/nodejs/node/issues/56993
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/56996
Fixes: https://github.com/nodejs/node/issues/56993
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
--------------------------------------------------------------------------------
⚠ Commits were pushed since the last approving review:
⚠ - fs: handle UV_ENOTDIR in `fs.statSync` with `throwIfNoEntry` provided
ℹ This PR was created on Mon, 10 Feb 2025 17:19:26 GMT
✔ Approvals: 2
✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/56996#pullrequestreview-2606783699
✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/56996#pullrequestreview-2610090803
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2025-02-13T21:19:39Z: https://ci.nodejs.org/job/node-test-pull-request/65193/
- Querying data for job/node-test-pull-request/65193/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/13336321966

jasnell pushed a commit that referenced this pull request Feb 15, 2025
@juanarbol@jasnell
fs: handle UV_ENOTDIR in fs.statSync with throwIfNoEntry provided
409e28d
Fixes: #56993
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #56996
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented Feb 15, 2025

Copy link
Copy Markdown
Member

Landed in 409e28d

@jasnelljasnell closed this Feb 15, 2025
targos pushed a commit that referenced this pull request Feb 17, 2025
@juanarbol@targos
fs: handle UV_ENOTDIR in fs.statSync with throwIfNoEntry provided
40f3a51
Fixes: #56993
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #56996
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
@juanarbol@acidiney
fs: handle UV_ENOTDIR in fs.statSync with throwIfNoEntry provided
0412220
Fixes: nodejs#56993
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: nodejs#56996
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Feb 25, 2025
Merged
aduh95 pushed a commit that referenced this pull request Apr 2, 2025
@juanarbol@aduh95
fs: handle UV_ENOTDIR in fs.statSync with throwIfNoEntry provided
5046831
Fixes: #56993
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #56996
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 3, 2025
@juanarbol@aduh95
fs: handle UV_ENOTDIR in fs.statSync with throwIfNoEntry provided
e96f83f
Fixes: #56993
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #56996
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95aduh95 mentioned this pull request Apr 11, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
@juanarbol@RafaelGSS
fs: handle UV_ENOTDIR in fs.statSync with throwIfNoEntry provided
2686396
Fixes: #56993
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #56996
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 17, 2025
@juanarbol@RafaelGSS
fs: handle UV_ENOTDIR in fs.statSync with throwIfNoEntry provided
b6df9e3
Fixes: #56993
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #56996
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@anonriganonriganonrig approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-failedAn error occurred while landing this pull request using GitHub Actions.fsIssues and PRs related to the fs subsystem / file system.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

statSync with throwIfNoEntry: false still throws ENOTDIR

5 participants

@juanarbol@nodejs-github-bot@jasnell@addaleax@anonrig