crypto: fix missing `OPENSSL_NO_ENGINE` guard by codebytere · Pull Request #57012 · nodejs/node

codebytere · 2025-02-12T12:17:23Z

Fixes compilation failure when OPENSSL_NO_ENGINE is defined:

../../third_party/electron_node/src/crypto/crypto_util.cc:32:16: error: no member named 'EnginePointer' in namespace 'ncrypto'; did you mean 'ECPointPointer'?
32 | using ncrypto::EnginePointer;
| ~~~~~~~~~^~~~~~~~~~~~~
| ECPointPointer
../../third_party/electron_node/deps/ncrypto/ncrypto.h:889:7: note: 'ECPointPointer' declared here
889 | class ECPointPointer final {
| ^
1 error generated.

nodejs-github-bot · 2025-02-12T12:17:28Z

Review requested:

@nodejs/crypto

nodejs-github-bot · 2025-02-13T18:05:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/65188/ 💚

nodejs-github-bot · 2025-02-14T12:26:18Z

Landed in fc7682c

PR-URL: #57012 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#57012 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #57012 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs/node#57012

* chore: bump node in DEPS to v22.15.0 * inspector: fix GN build nodejs/node#56798 * test: search cctest files nodejs/node#56791 * crypto: fix missing OPENSSL_NO_ENGINE guard nodejs/node#57012 * test,crypto: make tests work for BoringSSL nodejs/node#57021 * module: use synchronous hooks for preparsing in import(cjs) nodejs/node#55698 * deps: update simdjson to 3.12.0 nodejs/node#56874 * build: remove explicit linker call to libm on macOS nodejs/node#56901 * test: make eval snapshot comparison more flexible nodejs/node#57020 * src: allow embedder customization of OOMErrorHandler nodejs/node#57325 * src: do not pass nullptr to std::string ctor nodejs/node#57354 * src: lock the isolate properly in IsolateData destructor nodejs/node#57031 * chore: shrink --trace-atomics-wait patch * chore: fixup patch indices * build: fix GN build failure nodejs/node#57013 * crypto: expose security levels nodejs/node#56601 * zlib: add zstd support nodejs/node#52100 * test: move crypto related common utilities in common/crypto nodejs/node#56714 * cli: move --trace-atomics-wait to eol nodejs/node#52747 * test: disable test-https-client-renegotiation-limit BoringSSL doesn't support caller-initiated renegotiation - see https://source.chromium.org/chromium/chromium/src/+/main:third_party/boringssl/src/ssl/ssl_lib.cc;l=1627-1631 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

nodejs/node#57012

* chore: bump node in DEPS to v22.15.0 * inspector: fix GN build nodejs/node#56798 * test: search cctest files nodejs/node#56791 * crypto: fix missing OPENSSL_NO_ENGINE guard nodejs/node#57012 * test,crypto: make tests work for BoringSSL nodejs/node#57021 * module: use synchronous hooks for preparsing in import(cjs) nodejs/node#55698 * deps: update simdjson to 3.12.0 nodejs/node#56874 * build: remove explicit linker call to libm on macOS nodejs/node#56901 * test: make eval snapshot comparison more flexible nodejs/node#57020 * src: allow embedder customization of OOMErrorHandler nodejs/node#57325 * src: do not pass nullptr to std::string ctor nodejs/node#57354 * src: lock the isolate properly in IsolateData destructor nodejs/node#57031 * chore: shrink --trace-atomics-wait patch * chore: fixup patch indices * build: fix GN build failure nodejs/node#57013 * crypto: expose security levels nodejs/node#56601 * zlib: add zstd support nodejs/node#52100 * test: move crypto related common utilities in common/crypto nodejs/node#56714 * cli: move --trace-atomics-wait to eol nodejs/node#52747 * test: disable test-https-client-renegotiation-limit BoringSSL doesn't support caller-initiated renegotiation - see https://source.chromium.org/chromium/chromium/src/+/main:third_party/boringssl/src/ssl/ssl_lib.cc;l=1627-1631 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

nodejs/node#57012

* chore: bump node in DEPS to v22.15.0 * inspector: fix GN build nodejs/node#56798 * test: search cctest files nodejs/node#56791 * crypto: fix missing OPENSSL_NO_ENGINE guard nodejs/node#57012 * test,crypto: make tests work for BoringSSL nodejs/node#57021 * module: use synchronous hooks for preparsing in import(cjs) nodejs/node#55698 * deps: update simdjson to 3.12.0 nodejs/node#56874 * build: remove explicit linker call to libm on macOS nodejs/node#56901 * test: make eval snapshot comparison more flexible nodejs/node#57020 * src: allow embedder customization of OOMErrorHandler nodejs/node#57325 * src: do not pass nullptr to std::string ctor nodejs/node#57354 * build: fix GN build failure * build: fix patch indices * crypto: expose security levels nodejs/node#56601 * zlib: add zstd support nodejs/node#52100 * test: move crypto related common utilities in common/crypto nodejs/node#56714 * test: disable test-https-client-renegotiation-limit BoringSSL doesn't support caller-initiated renegotiation - see https://source.chromium.org/chromium/chromium/src/+/main:third_party/boringssl/src/ssl/ssl_lib.cc;l=1627-1631 * chore: fixup indices --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

* chore: bump node in DEPS to v22.15.0 * inspector: fix GN build nodejs/node#56798 * test: search cctest files nodejs/node#56791 * crypto: fix missing OPENSSL_NO_ENGINE guard nodejs/node#57012 * test,crypto: make tests work for BoringSSL nodejs/node#57021 * module: use synchronous hooks for preparsing in import(cjs) nodejs/node#55698 * deps: update simdjson to 3.12.0 nodejs/node#56874 * build: remove explicit linker call to libm on macOS nodejs/node#56901 * test: make eval snapshot comparison more flexible nodejs/node#57020 * src: allow embedder customization of OOMErrorHandler nodejs/node#57325 * src: do not pass nullptr to std::string ctor nodejs/node#57354 * src: lock the isolate properly in IsolateData destructor nodejs/node#57031 * chore: shrink --trace-atomics-wait patch * chore: fixup patch indices * build: fix GN build failure nodejs/node#57013 * crypto: expose security levels nodejs/node#56601 * zlib: add zstd support nodejs/node#52100 * test: move crypto related common utilities in common/crypto nodejs/node#56714 * cli: move --trace-atomics-wait to eol nodejs/node#52747 * test: disable test-https-client-renegotiation-limit BoringSSL doesn't support caller-initiated renegotiation - see https://source.chromium.org/chromium/chromium/src/+/main:third_party/boringssl/src/ssl/ssl_lib.cc;l=1627-1631 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

codebytere requested a review from jasnell February 12, 2025 12:17

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Feb 12, 2025

codebytere force-pushed the openssl-no-engine branch from fc30ed0 to 25f11b0Compare February 12, 2025 12:20

crypto: fix missing OPENSSL_NO_ENGINE guard
c417004

codebytere force-pushed the openssl-no-engine branch from 25f11b0 to c417004Compare February 12, 2025 12:21

richardlau approved these changes Feb 12, 2025
View reviewed changes

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 12, 2025

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 12, 2025

This comment was marked as outdated.
Sign in to view

joyeecheung approved these changes Feb 12, 2025
View reviewed changes

lpinca approved these changes Feb 12, 2025
View reviewed changes

This comment was marked as outdated.
Sign in to view

codebytere mentioned this pull request Feb 13, 2025
chore: bump node to v22.14.0 (main) electron/electron#45578
Merged

jasnell approved these changes Feb 14, 2025
View reviewed changes

jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 14, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 14, 2025

nodejs-github-bot merged commit fc7682c into nodejs:mainFeb 14, 2025

github-actionsBot mentioned this pull request Feb 25, 2025
2025-02-26, Version 23.9.0 (Current) #57207
Merged

aduh95 mentioned this pull request Apr 11, 2025
2025-04-23, Version 22.15.0 'Jod' (LTS), @UlisesGascon prepared by @RafaelGSS #57840
Merged

codebytere added a commit to electron/electron that referenced this pull request Apr 25, 2025
crypto: fix missing OPENSSL_NO_ENGINE guard
c81e9f3
nodejs/node#57012

codebytere added a commit to electron/electron that referenced this pull request Apr 25, 2025
crypto: fix missing OPENSSL_NO_ENGINE guard
e9f4bc9
nodejs/node#57012

codebytere added a commit to electron/electron that referenced this pull request May 1, 2025
crypto: fix missing OPENSSL_NO_ENGINE guard
68a196f
nodejs/node#57012

codebytere added a commit to electron/electron that referenced this pull request May 5, 2025
crypto: fix missing OPENSSL_NO_ENGINE guard
6e9a181
nodejs/node#57012

codebytere added a commit to electron/electron that referenced this pull request May 6, 2025
crypto: fix missing OPENSSL_NO_ENGINE guard
b7c2c9e
nodejs/node#57012

codebytere added a commit to electron/electron that referenced this pull request May 7, 2025
crypto: fix missing OPENSSL_NO_ENGINE guard
89438df
nodejs/node#57012

Navigation Menu

Uh oh!

Uh oh!

crypto: fix missing `OPENSSL_NO_ENGINE` guard - #57012

crypto: fix missing `OPENSSL_NO_ENGINE` guard#57012
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
codebytere:openssl-no-engine

codebytere commented Feb 12, 2025

Uh oh!

nodejs-github-bot commented Feb 12, 2025

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Feb 13, 2025•
edited by jasnell
Loading

Uh oh!

nodejs-github-bot commented Feb 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

codebytere commented Feb 12, 2025

Uh oh!

nodejs-github-bot commented Feb 12, 2025

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Feb 13, 2025• edited by jasnell Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Feb 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nodejs-github-bot commented Feb 13, 2025•
edited by jasnell
Loading