Uh oh!
There was an error while loading. Please reload this page.
doc: align doc/api/tls.markdown with style guide and fix minor grammatical issues - #5706
doc: align doc/api/tls.markdown with style guide and fix minor grammatical issues#5706svozza wants to merge 1 commit into
Conversation
5e04f4b to
1b2aab8CompareThere was a problem hiding this comment.
Nit: wouldn't it be more correct to say it implements the duplex stream interface (singular)?
benjamingr
commented
Mar 15, 2016
Very nice contribution - I left some comments - when those are addressed LGTM. |
svozza
commented
Mar 15, 2016
Cool. I've addressed all the comments bar the two I need clarification on. I'll push the changes together when they're all done. |
d6c2422 to
e87183cComparesvozza
commented
Mar 15, 2016
So I think I've addressed all the comments. |
benjamingr
commented
Mar 15, 2016
Great, LGTM. Allow me to clarify the process - pull requests are open for 48 hours during week days in order to give collaborators opportunity to respond to them and suggest changes. In a day and a half assuming no one has objections (and hopefully more people read this) this will be landed in master. Pinging @nodejs/documentation in order to draw more attention to this issue since it's a big copy change. |
svozza
commented
Mar 15, 2016
Good stuff. :) |
3a9d37a to
cb8297fCompareBrings tls.markdown into alignment with the node.js styleguide, specifically regarding the use of personal pronouns. Also, fixes various typos, punctuation errors, missing definite/indefinite articles and other minor grammatical issues.
cb8297f to
f246ec3Comparesvozza
commented
Mar 15, 2016
Actually, something I noticed is that none of the anchor links in the file work when I view the markdown files in the browser. Take, for example, this one which is supposed to point to |
jasnell
commented
Mar 16, 2016
LGTM |
Brings tls.markdown into alignment with the node.js styleguide, specifically regarding the use of personal pronouns. Also, fixes various typos, punctuation errors, missing definite/indefinite articles and other minor grammatical issues. PR-URL: #5706 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
benjamingr
commented
Mar 20, 2016
Landed in 4f6ad5c 🎈🎈🎈 Thanks again. |
svozza
commented
Mar 20, 2016
👍 |
Brings tls.markdown into alignment with the node.js styleguide, specifically regarding the use of personal pronouns. Also, fixes various typos, punctuation errors, missing definite/indefinite articles and other minor grammatical issues. PR-URL: #5706 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Conflicts: doc/api/tls.markdown
MylesBorins
commented
Mar 30, 2016
4f6ad5c is not landing cleanly onto v4.x-staging. Would someone be willing to backport? |
svozza
commented
Mar 31, 2016
I can try, what exactly do I have to do? Just checkout the |
MylesBorins
commented
Mar 31, 2016
@svozza check out |
svozza
commented
Mar 31, 2016
Good stuff. I'll give that a go. |
Brings tls.markdown into alignment with the node.js styleguide, specifically regarding the use of personal pronouns. Also, fixes various typos, punctuation errors, missing definite/indefinite articles and other minor grammatical issues. PR-URL: nodejs#5706 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Affected core subsystem(s)
Doc, TLS
Description of change
As discussed in #5677 (and tangentially, nodejs/docs#87) I've broken out the extra changes originally made in that PR into a separate one. Brings
tls.markdowninto alignment with the Node.js styleguide, specifically regarding the use of personal pronouns. Also, fixes various typos, punctuation errors, line wrapping violations, missing definite/indefinite articles and other minor grammatical issues.