Skip to content

sea: suppress builtin warning with disableExperimentalSEAWarning option - #57086

Closed
koooge wants to merge 1 commit into
nodejs:mainfrom
koooge:sea-disable-builtin-warning
Closed

sea: suppress builtin warning with disableExperimentalSEAWarning option#57086
koooge wants to merge 1 commit into
nodejs:mainfrom
koooge:sea-disable-builtin-warning

Conversation

@koooge

@kooogekoooge commented Feb 16, 2025

Copy link
Copy Markdown
Contributor

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 16, 2025
joyeecheung
joyeecheung reviewed Feb 16, 2025
View reviewed changes
Comment threadlib/internal/main/embedding.js Outdated
@codecov

codecovBot commented Feb 16, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.09%. Comparing base (59cdd4f) to head (42af3be).
Report is 22 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #57086 +/- ##
==========================================
- Coverage 89.10% 89.09% -0.02% 
==========================================
Files 665 665 Lines 193203 193250 +47 Branches 37216 37226 +10 ==========================================
+ Hits 172163 172175 +12 - Misses 13767 13805 +38 + Partials 7273 7270 -3
Files with missing linesCoverage Δ
lib/internal/main/embedding.js88.88% <100.00%> (+0.09%)⬆️

... and 26 files with indirect coverage changes

@koooge
kooogeforce-pushed the sea-disable-builtin-warning branch from dec12c5 to 42af3beCompareFebruary 16, 2025 10:22
@joyeecheungjoyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 16, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 16, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@joyeecheungjoyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 17, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 17, 2025
@nodejs-github-bot

nodejs-github-bot commented Feb 17, 2025•
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65273/ 💛

jasnell pushed a commit that referenced this pull request Feb 18, 2025
@koooge@jasnell
sea: suppress builtin warning with disableExperimentalSEAWarning option
6fe0723
Signed-off-by: koooge <koooooge@gmail.com>
PR-URL: #57086
Refs: nodejs/single-executable#107
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented Feb 18, 2025

Copy link
Copy Markdown
Member

Landed in 6fe0723

@jasnelljasnell closed this Feb 18, 2025
acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
@koooge@acidiney
sea: suppress builtin warning with disableExperimentalSEAWarning option
4f02009
Signed-off-by: koooge <koooooge@gmail.com>
PR-URL: nodejs#57086
Refs: nodejs/single-executable#107
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Feb 24, 2025
@koooge@targos
sea: suppress builtin warning with disableExperimentalSEAWarning option
f2db69a
Signed-off-by: koooge <koooooge@gmail.com>
PR-URL: #57086
Refs: nodejs/single-executable#107
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Feb 25, 2025
Merged
targos pushed a commit that referenced this pull request Feb 25, 2025
@koooge@targos
sea: suppress builtin warning with disableExperimentalSEAWarning option
ac35106
Signed-off-by: koooge <koooooge@gmail.com>
PR-URL: #57086
Refs: nodejs/single-executable#107
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 2, 2025
@koooge@aduh95
sea: suppress builtin warning with disableExperimentalSEAWarning option
1e0f3d6
Signed-off-by: koooge <koooooge@gmail.com>
PR-URL: #57086
Refs: nodejs/single-executable#107
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 3, 2025
@koooge@aduh95
sea: suppress builtin warning with disableExperimentalSEAWarning option
3110e64
Signed-off-by: koooge <koooooge@gmail.com>
PR-URL: #57086
Refs: nodejs/single-executable#107
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95aduh95 mentioned this pull request Apr 11, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
@koooge@RafaelGSS
sea: suppress builtin warning with disableExperimentalSEAWarning option
8cfa144
Signed-off-by: koooge <koooooge@gmail.com>
PR-URL: #57086
Refs: nodejs/single-executable#107
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 17, 2025
@koooge@RafaelGSS
sea: suppress builtin warning with disableExperimentalSEAWarning option
dfcd9b1
Signed-off-by: koooge <koooooge@gmail.com>
PR-URL: #57086
Refs: nodejs/single-executable#107
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@koooge@nodejs-github-bot@jasnell@joyeecheung