Uh oh!
There was an error while loading. Please reload this page.
test: simplify test-http2-client-promisify-connect-error - #57144
Merged
nodejs-github-bot merged 1 commit intoFeb 22, 2025
Merged
Conversation
lpinca
commented
Feb 20, 2025
MemberAuthor
The first commit is from #57135. |
aduh95
reviewed
Feb 20, 2025
Uh oh!
There was an error while loading. Please reload this page.
lpincaforce-pushed
the
simply/test-http2-client-promisify-connect-error
branch
from
February 20, 2025 09:35
2a147c9 to
03aa1f6Compareaduh95
approved these changes
Feb 20, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #57144 +/- ##
==========================================
+ Coverage 90.35% 90.36% +0.01%
==========================================
Files 629 629 Lines 184308 184308 Branches 36015 36009 -6 ==========================================
+ Hits 166532 166551 +19 - Misses 10909 10911 +2 + Partials 6867 6846 -21 |
aduh95
commented
Feb 20, 2025
Contributor
Let's wait for #57135 to land before running CI as we'd have to rebase anyway |
nodejs-github-bot
commented
Feb 20, 2025
Collaborator
joyeecheung
approved these changes
Feb 20, 2025
There is no need to try to create a TCP connection that fails due to a missing listening server. Also, the port used for the connection might be used by another process when the connection is made.
lpincaforce-pushed
the
simply/test-http2-client-promisify-connect-error
branch
from
February 21, 2025 11:44
03aa1f6 to
42a53b8Comparenodejs-github-bot
commented
Feb 21, 2025
Collaborator
nodejs-github-bot
commented
Feb 21, 2025
Collaborator
nodejs-github-bot
commented
Feb 22, 2025
Collaborator
aduh95
approved these changes
Feb 22, 2025
nodejs-github-bot
commented
Feb 22, 2025
Collaborator
Landed in ba8fbf3 |
acidiney pushed a commit
to acidiney/node
that referenced
this pull request
Feb 23, 2025
There is no need to try to create a TCP connection that fails due to a missing listening server. Also, the port used for the connection might be used by another process when the connection is made. PR-URL: nodejs#57144 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos pushed a commit
that referenced
this pull request
Feb 24, 2025
There is no need to try to create a TCP connection that fails due to a missing listening server. Also, the port used for the connection might be used by another process when the connection is made. PR-URL: #57144 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos pushed a commit
that referenced
this pull request
Feb 25, 2025
There is no need to try to create a TCP connection that fails due to a missing listening server. Also, the port used for the connection might be used by another process when the connection is made. PR-URL: #57144 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Apr 2, 2025
There is no need to try to create a TCP connection that fails due to a missing listening server. Also, the port used for the connection might be used by another process when the connection is made. PR-URL: #57144 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Apr 3, 2025
There is no need to try to create a TCP connection that fails due to a missing listening server. Also, the port used for the connection might be used by another process when the connection is made. PR-URL: #57144 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
Apr 16, 2025
There is no need to try to create a TCP connection that fails due to a missing listening server. Also, the port used for the connection might be used by another process when the connection is made. PR-URL: #57144 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
Apr 17, 2025
There is no need to try to create a TCP connection that fails due to a missing listening server. Also, the port used for the connection might be used by another process when the connection is made. PR-URL: #57144 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need to try to create a TCP connection that fails due to a
missing listening server. Also, the port used for the connection might
be used by another process when the connection is made.