Skip to content

lib: fix ImportModuleDynamicallyCallback return type declaration - #57160

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
legendecas:modules/ImportModuleDynamicallyCallback
Feb 21, 2025
Merged

lib: fix ImportModuleDynamicallyCallback return type declaration#57160
aduh95 merged 1 commit into
nodejs:mainfrom
legendecas:modules/ImportModuleDynamicallyCallback

Conversation

@legendecas

@legendecaslegendecas commented Feb 21, 2025

Copy link
Copy Markdown
Member

@nodejs-github-bot

nodejs-github-bot commented Feb 21, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-botnodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Feb 21, 2025
@legendecaslegendecas mentioned this pull request Feb 21, 2025
Closed
@codecov

codecovBot commented Feb 21, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.36%. Comparing base (15fec13) to head (6b0b25e).
Report is 14 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #57160 +/- ##
==========================================
+ Coverage 89.02% 90.36% +1.33% 
==========================================
Files 665 629 -36 Lines 193408 184314 -9094 Branches 37275 36008 -1267 ==========================================
- Hits 172180 166548 -5632 + Misses 13891 10910 -2981 + Partials 7337 6856 -481
Files with missing linesCoverage Δ
lib/internal/modules/esm/loader.js97.01% <100.00%> (-0.86%)⬇️
lib/internal/modules/esm/utils.js98.90% <100.00%> (+0.01%)⬆️

... and 87 files with indirect coverage changes

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. typings and removed needs-ci PRs that need a full CI run. labels Feb 21, 2025
@aduh95aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 21, 2025
@github-actions

github-actionsBot commented Feb 21, 2025

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@aduh95
aduh95 merged commit 90ab559 into nodejs:mainFeb 21, 2025
@aduh95

aduh95 commented Feb 21, 2025

Copy link
Copy Markdown
Contributor

Landed in 90ab559

@legendecas
legendecas deleted the modules/ImportModuleDynamicallyCallback branch February 21, 2025 17:57
acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
@legendecas@acidiney
typings: fix ImportModuleDynamicallyCallback return type
3717a24
PR-URL: nodejs#57160
Refs: https://github.com/nodejs/node/pull/56919/files#r1955336054
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Feb 24, 2025
@legendecas@targos
typings: fix ImportModuleDynamicallyCallback return type
e8c5acf
PR-URL: #57160
Refs: https://github.com/nodejs/node/pull/56919/files#r1955336054
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Feb 25, 2025
Merged
targos pushed a commit that referenced this pull request Feb 25, 2025
@legendecas@targos
typings: fix ImportModuleDynamicallyCallback return type
c6d6be2
PR-URL: #57160
Refs: https://github.com/nodejs/node/pull/56919/files#r1955336054
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 2, 2025
@legendecas@aduh95
typings: fix ImportModuleDynamicallyCallback return type
683dcec
PR-URL: #57160
Refs: https://github.com/nodejs/node/pull/56919/files#r1955336054
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 3, 2025
@legendecas@aduh95
typings: fix ImportModuleDynamicallyCallback return type
c03648b
PR-URL: #57160
Refs: https://github.com/nodejs/node/pull/56919/files#r1955336054
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95aduh95 mentioned this pull request Apr 11, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
@legendecas@RafaelGSS
typings: fix ImportModuleDynamicallyCallback return type
857b66d
PR-URL: #57160
Refs: https://github.com/nodejs/node/pull/56919/files#r1955336054
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 17, 2025
@legendecas@RafaelGSS
typings: fix ImportModuleDynamicallyCallback return type
6dab980
PR-URL: #57160
Refs: https://github.com/nodejs/node/pull/56919/files#r1955336054
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
@legendecas@marco-ippolito
typings: fix ImportModuleDynamicallyCallback return type
4592bd3
PR-URL: #57160
Refs: https://github.com/nodejs/node/pull/56919/files#r1955336054
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@marco-ippolitomarco-ippolito mentioned this pull request Jun 5, 2025
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 10, 2025
@legendecas@marco-ippolito
typings: fix ImportModuleDynamicallyCallback return type
a5cd4bc
PR-URL: #57160
Refs: https://github.com/nodejs/node/pull/56919/files#r1955336054
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jun 11, 2025
@legendecas@marco-ippolito
typings: fix ImportModuleDynamicallyCallback return type
1521125
PR-URL: #57160
Refs: https://github.com/nodejs/node/pull/56919/files#r1955336054
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@aduh95aduh95aduh95 approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.esmIssues and PRs related to the ECMAScript Modules implementation.fast-trackPRs that do not need to wait for 48 hours to land.typings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@legendecas@nodejs-github-bot@aduh95@jasnell@marco-ippolito