Uh oh!
There was an error while loading. Please reload this page.
deps: update ada to 3.1.1 - #57190
Closed
nodejs-github-bot wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
Feb 24, 2025
CollaboratorAuthor
Review requested:
|
anonrig
commented
Feb 24, 2025
Member
@nodejs/performance can someone run url benchmarks? |
anonrig
approved these changes
Feb 24, 2025
anonrig
commented
Feb 24, 2025
Member
@lemire any idea why we didn't catch this on CI? |
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Feb 24, 2025
CollaboratorAuthor
aduh95
commented
Feb 24, 2025
Contributor
|
richardlau
commented
Feb 24, 2025
Member
Should be fixed by #57197 (was a race condition between two separate PR's landing on |
RafaelGSS
approved these changes
Feb 24, 2025
anonrig
commented
Feb 24, 2025
Member
@richardlau any idea why github 24.04 succeeds but arm doesn't? somehow -Wsign-compare is enabled on github ci for both macos and ubuntu 24.04 |
richardlau
commented
Feb 24, 2025
Member
@anonrig Some of the CI runs with |
richardlau
commented
Feb 24, 2025
Member
hmm but that is set on both the arm and non-arm Ubuntu 24.04 GitHub workflows. I can only assume either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of ada to 3.1.1.