Skip to content

docs: Add note that process.send and child.send use JSON.stringify() - #5723

Closed
mithun-daa wants to merge 1 commit into
nodejs:masterfrom
mithun-daa:doc-5453
Closed

docs: Add note that process.send and child.send use JSON.stringify()#5723
mithun-daa wants to merge 1 commit into
nodejs:masterfrom
mithun-daa:doc-5453

Conversation

@mithun-daa

@mithun-daamithun-daa commented Mar 15, 2016

Copy link
Copy Markdown
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Affected core subsystem(s)

Please provide affected core subsystem(s) (like buffer, cluster, crypto, etc)

docs

Description of change

Please provide a description of the change here.

Explicitly call out that the send method on both process and child uses JSON.stringify to serialize the message
Fixes#5453

@mithun-daa
docs: Add note that process.send and child.send use JSON.stringify()
62031d6
Explicitly call out that the send method on both process and child uses JSON.stringify to serialize the message
Fixesnodejs#5453
@Fishrock123Fishrock123 added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Mar 15, 2016
@jasnell

jasnell commented Mar 15, 2016

Copy link
Copy Markdown
Member

LGTM

@whitlockjc

whitlockjc commented Mar 15, 2016

Copy link
Copy Markdown
Contributor

LGTM

1 similar comment
@cjihrig

cjihrig commented Mar 15, 2016

Copy link
Copy Markdown
Contributor

LGTM

jasnell pushed a commit that referenced this pull request Mar 15, 2016
@mithun-daa@jasnell
doc: Add note about use of JSON.stringify()
99a5d07
process.send and child.send use JSON.stringify to serialize
the message.
Fixes: #5453
PR-URL: #5723
Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented Mar 15, 2016

Copy link
Copy Markdown
Member

Landed in 99a5d07

@mithun-daa ... thank you for the PR! I did update the commit message a bit to conform to our commit guidelines.

@jasnelljasnell closed this Mar 15, 2016
evanlucas pushed a commit that referenced this pull request Mar 15, 2016
@mithun-daa@evanlucas
doc: Add note about use of JSON.stringify()
3444a66
process.send and child.send use JSON.stringify to serialize
the message.
Fixes: #5453
PR-URL: #5723
Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucasevanlucas mentioned this pull request Mar 15, 2016
Merged
rvagg pushed a commit that referenced this pull request Mar 16, 2016
@mithun-daa@rvagg
doc: Add note about use of JSON.stringify()
434af03
process.send and child.send use JSON.stringify to serialize
the message.
Fixes: #5453
PR-URL: #5723
Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
@mithun-daaMyles Borins
doc: Add note about use of JSON.stringify()
ffc69e6
process.send and child.send use JSON.stringify to serialize
the message.
Fixes: #5453
PR-URL: #5723
Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins added land-on-v4.x and removed doc Issues and PRs related to the documentations. labels Mar 17, 2016
@MylesBorinsMylesBorins added doc Issues and PRs related to the documentations. and removed lts-watch-v4.x labels Mar 21, 2016
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
@mithun-daaMyles Borins
doc: Add note about use of JSON.stringify()
fa3ed70
process.send and child.send use JSON.stringify to serialize
the message.
Fixes: #5453
PR-URL: #5723
Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
@mithun-daaMyles Borins
doc: Add note about use of JSON.stringify()
e572542
process.send and child.send use JSON.stringify to serialize
the message.
Fixes: #5453
PR-URL: #5723
Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ChALkeRChALkeR mentioned this pull request Apr 24, 2016
Closed
@karencapiirokarencapiiro mentioned this pull request Nov 30, 2023
Open
@AshdonGAshdonG mentioned this pull request Dec 1, 2023
Open
@BryanLauraBryanLaura mentioned this pull request Dec 1, 2023
Open
@SupermajestcdSupermajestcd mentioned this pull request Dec 1, 2023
Open
This was referenced Dec 1, 2023
Open
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

child_processIssues and PRs related to the child_process subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Child Process send incorrectly serializes values

6 participants

@mithun-daa@jasnell@whitlockjc@cjihrig@MylesBorins@Fishrock123