Uh oh!
There was an error while loading. Please reload this page.
test: minimize test-http-get-pipeline-problem - #5728
Conversation
Reduce resoures required by test. Clarify comment explaining source of test and what the test is looking for. Fixes: nodejs#5725
Trott
commented
Mar 15, 2016
Stress test showing flakiness on current master: https://ci.nodejs.org/job/node-stress-single-test/560/nodes=pi2-raspbian-wheezy/console |
Trott
commented
Mar 15, 2016
For context: Here's a gist from @mikeal who originally reported the bug: https://gist.githubusercontent.com/mikeal/864727/raw/561f3b665df0faff6d3ee9601ef31cc3caf0376f/gistfile1.js That code fails on Node.js 0.6.0 and succeeds in 0.6.21. If we change it to this, it still failsin Node.js 0.6.0 and succeeds in 0.6.21: The key is that |
Trott
commented
Mar 16, 2016
Stress test to hopefully show that this is not flaky. Hope I didn't typo in the parameters... https://ci.nodejs.org/job/node-stress-single-test/563/nodes=pi2-raspbian-wheezy/console |
Trott
commented
Mar 18, 2016
Bump. /cc @nodejs/testing |
santigimeno
commented
Mar 18, 2016
LGTM |
cjihrig
commented
Mar 20, 2016
LGTM |
1 similar comment
jasnell
commented
Mar 21, 2016
LGTM |
jasnell
commented
Mar 21, 2016
Landed in ccb7b45 |
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
test, http
Description of change
Reduce resoures required by test. Fixes test flakiness on Raspberry Pi in CI.
Clarify comment explaining source of test and what the test is looking
for.
Fixes: #5725