Skip to content

watch: check parent and child path properly - #57425

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
jazelly:fix-57422
Apr 6, 2025
Merged

watch: check parent and child path properly#57425
aduh95 merged 1 commit into
nodejs:mainfrom
jazelly:fix-57422

Conversation

@jazelly

@jazellyjazelly commented Mar 12, 2025

Copy link
Copy Markdown
Member

Fixes: #57422

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 12, 2025
@jazelly
jazellyforce-pushed the fix-57422 branch 3 times, most recently from bb7f643 to 7a81702CompareMarch 12, 2025 14:26
@jakecastellijakecastelli added the watch-mode Issues and PRs related to watch mode label Mar 12, 2025
anonrig
anonrig reviewed Mar 12, 2025
View reviewed changes
Comment threadlib/internal/watch_mode/files_watcher.js Outdated
@codecov

codecovBot commented Mar 12, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.23%. Comparing base (59f00d7) to head (dc04bc4).
Report is 165 commits behind head on main.

Files with missing linesPatch %Lines
lib/internal/watch_mode/files_watcher.js90.90%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #57425 +/- ##
==========================================
+ Coverage 90.21% 90.23% +0.01% 
==========================================
Files 629 629 Lines 185126 184963 -163 Branches 36225 36223 -2 ==========================================
- Hits 167016 166900 -116 + Misses 11055 11019 -36 + Partials 7055 7044 -11
Files with missing linesCoverage Δ
lib/internal/watch_mode/files_watcher.js89.20% <90.90%> (-0.07%)⬇️

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jazelly
jazellyforce-pushed the fix-57422 branch 2 times, most recently from a9aa5b0 to 711c301CompareMarch 12, 2025 23:50
@jazellyjazelly added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 13, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 13, 2025
@nodejs-github-bot

nodejs-github-bot commented Mar 13, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65711/

@nodejs-github-bot

nodejs-github-bot commented Mar 13, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65713/

aduh95
aduh95 reviewed Mar 13, 2025
View reviewed changes
Comment threadtest/parallel/test-watch-mode-files_watcher.mjs Outdated
@jazellyjazelly added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 14, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 14, 2025
@nodejs-github-bot

nodejs-github-bot commented Mar 14, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65731/

@jakecastelli

jakecastelli commented Mar 14, 2025

Copy link
Copy Markdown
Member

Hi folks @nodejs/build - could you take a look at this failure fatal error C1060: compiler is out of heap space [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers_host.vcxproj] from https://ci.nodejs.org/job/node-compile-windows/60923/nodes=win-vs2022-arm64/

aduh95
aduh95 reviewed Mar 14, 2025
View reviewed changes
Comment threadtest/parallel/test-watch-mode-files_watcher.mjs Outdated
aduh95
aduh95 reviewed Mar 14, 2025
View reviewed changes
Comment threadtest/parallel/test-watch-mode-files_watcher.mjs Outdated
aduh95
aduh95 approved these changes Mar 15, 2025
View reviewed changes
Comment threadtest/parallel/test-watch-mode-files_watcher.mjs Outdated
Comment threadtest/parallel/test-watch-mode-files_watcher.mjs Outdated
@jazelly@jakecastelli
watch: check parent and child path properly
dc04bc4
co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
@jazellyjazelly added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 16, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 16, 2025
@nodejs-github-bot

nodejs-github-bot commented Mar 16, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65780/

@nodejs-github-bot

nodejs-github-bot commented Mar 16, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65789/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 16, 2025
@nodejs-github-bot

nodejs-github-bot commented Mar 17, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65795/

@nodejs-github-bot

nodejs-github-bot commented Mar 18, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65815/

@richardsimkorichardsimko mentioned this pull request Mar 18, 2025
Closed
@jazellyjazelly added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 4, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 4, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 4, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66016/

@nodejs-github-bot

nodejs-github-bot commented Apr 5, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66067/

@nodejs-github-bot

nodejs-github-bot commented Apr 5, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66072/

@aduh95
aduh95 merged commit 8456a12 into nodejs:mainApr 6, 2025
@aduh95

aduh95 commented Apr 6, 2025

Copy link
Copy Markdown
Contributor

Landed in 8456a12

RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@jazelly@jakecastelli@RafaelGSS
watch: check parent and child path properly
2aa957a
Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
PR-URL: #57425Fixes: #57422
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@RafaelGSSRafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@jazelly@jakecastelli@RafaelGSS
watch: check parent and child path properly
6556212
Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
PR-URL: #57425Fixes: #57422
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@jazelly@jakecastelli@aduh95
watch: check parent and child path properly
5401430
Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
PR-URL: #57425Fixes: #57422
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@jazelly@jakecastelli@RafaelGSS
watch: check parent and child path properly
bed7d3e
Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
PR-URL: #57425Fixes: #57422
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@jazelly@jakecastelli@aduh95
watch: check parent and child path properly
96d6a28
Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
PR-URL: #57425Fixes: #57422
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@jazelly@jakecastelli@aduh95
watch: check parent and child path properly
f72ddcd
Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
PR-URL: #57425Fixes: #57422
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@github-actionsgithub-actionsBot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@jazelly@jakecastelli@aduh95
watch: check parent and child path properly
7229a29
Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
PR-URL: #57425Fixes: #57422
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@ghostghost mentioned this pull request Jun 8, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig left review comments
@jasnelljasnelljasnell approved these changes
@MoLowMoLowMoLow approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.watch-modeIssues and PRs related to watch mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Watch not working on paths with overlap

8 participants

@jazelly@nodejs-github-bot@jakecastelli@aduh95@jasnell@anonrig@MoLow@BridgeAR