Uh oh!
There was an error while loading. Please reload this page.
buffer: backport --zero-fill-buffers command line option - #5748
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
jasnell
commented
Mar 16, 2016
MemberAuthor
Talking to @trevnorris about this, he suggested just changing the behavior of smalloc if --zero-fill-buffers is set. |
jasnellforce-pushed
the
v0.12-zero-fill-buffers
branch
from
March 16, 2016 23:48
c829599 to
4c16bd6CompareThis backports the --zero-fill-buffers command line flag introduced in master. When used, all Buffer and SlowBuffer instances will zero fill by default. This does *not* backport any of the other Buffer API or behavior changes.
jasnellforce-pushed
the
v0.12-zero-fill-buffers
branch
from
March 17, 2016 00:22
4c16bd6 to
9841681Comparejasnell
commented
Mar 17, 2016
MemberAuthor
@nodejs/ctc |
This was referenced Mar 21, 2016
jasnell
commented
Mar 23, 2016
MemberAuthor
CTC decision today to hold off landing this in v0.12 for now. Will keep the PR open. @nodejs/lts |
jasnell
commented
May 1, 2016
MemberAuthor
Closing. Can reopen if we ultimately decide to do this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
buffer
Description of change
This backports the --zero-fill-buffers command line flag introduced in master. When used, all Buffer and SlowBuffer instances will zero fill by default.
This does not backport any of the other Buffer API or behavior changes.
Note: My intent is to open similar backports for
--zero-fill-bufferin v5, v4, and v0.10/cc @trevnorris @nodejs/lts