Skip to content

src: remove deleted tls file - #57481

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
codebytere:fix-gn-build
Mar 17, 2025
Merged

src: remove deleted tls file#57481
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
codebytere:fix-gn-build

Conversation

@codebytere

@codebyterecodebytere commented Mar 15, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Refs #57361

cc @JonasBa

Fixes the following:

node on git:main ❯ ninja -C out/Release 10:13AM
ninja: Entering directory `out/Release'
ninja: error: '../../lib/internal/tls/secure-pair.js', needed by 'gen/node_javascript.cc', missing and no known rule to make it

@nodejs-github-bot

nodejs-github-bot commented Mar 15, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 15, 2025
@codecov

codecovBot commented Mar 15, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (72aa2ea) to head (5832d63).
Report is 21 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #57481 +/- ##
=======================================
Coverage 90.22% 90.22% =======================================
Files 629 629 Lines 184948 184948 Branches 36207 36204 -3 =======================================
+ Hits 166865 166871 +6 - Misses 11029 11033 +4 + Partials 7054 7044 -10
Files with missing linesCoverage Δ
src/node_builtins.cc77.99% <ø> (ø)

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 15, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2025
@nodejs-github-bot

nodejs-github-bot commented Mar 15, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65769/

@anonriganonrig added the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 15, 2025
@addaleax

addaleax commented Mar 15, 2025

Copy link
Copy Markdown
Member

@anonrig Did you mean to add the semver-major label?

@nodejs-github-bot

nodejs-github-bot commented Mar 15, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65772/

@anonrig

anonrig commented Mar 16, 2025

Copy link
Copy Markdown
Member

@anonrig Did you mean to add the semver-major label?

@addaleax Yes because the original PR is a semver-major. This fix should be a semver major as well.

@aduh95

aduh95 commented Mar 16, 2025

Copy link
Copy Markdown
Contributor

@anonrig Did you mean to add the semver-major label?

@addaleax Yes because the original PR is a semver-major. This fix should be a semver major as well.

That's not correct, it should not be semver-major as it is not a breaking change. We have the dont-land- labels for this kind of change that should not be backported while not being semver-major.

@aduh95aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. and removed semver-major PRs that contain breaking changes and should be released in the next major version. labels Mar 16, 2025
@anonrig

anonrig commented Mar 16, 2025

Copy link
Copy Markdown
Member

@aduh95 TIL. Thanks!

@JonasBa

JonasBa commented Mar 16, 2025

Copy link
Copy Markdown
Contributor

Thank you @codebytere.

Maybe this is not the right place to ask, but how could I have caught this in my PR? Are there some obvious steps that I missed? Again, sorry for breaking this, and thank you for fixing it ❤️

@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 17, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 7584284 into nodejs:mainMar 17, 2025
@nodejs-github-bot

nodejs-github-bot commented Mar 17, 2025

Copy link
Copy Markdown
Collaborator

Landed in 7584284

RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@codebytere@RafaelGSS
src: remove deleted tls file
755a5b9
PR-URL: #57481
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@codebytere@RafaelGSS
src: remove deleted tls file
edb5c87
PR-URL: #57481
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@codebytere@RafaelGSS
src: remove deleted tls file
e4ff2b6
PR-URL: #57481
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@anonriganonriganonrig approved these changes
@meixgmeixgmeixg approved these changes
@aduh95aduh95aduh95 approved these changes
@joyeecheungjoyeecheungAwaiting requested review from joyeecheung

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@codebytere@nodejs-github-bot@addaleax@anonrig@aduh95@JonasBa@lpinca@meixg