Skip to content

doc: correct status of require(esm) warning in v20 changelog - #57529

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:update-changelog
Mar 19, 2025
Merged

doc: correct status of require(esm) warning in v20 changelog#57529
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:update-changelog

Conversation

@joyeecheung

@joyeecheungjoyeecheung commented Mar 18, 2025

Copy link
Copy Markdown
Member

The backported patches already include the commit that disables the warning unless --trace-require-module is explicitly used. Correct the changelog to match the status.

Fixes: #57517

The backported patches already include the commit that disables
the warning unless `--trace-require-module` is explicitly used.
Correct the changelog to match the status.
@nodejs-github-botnodejs-github-bot added the release Issues and PRs related to Node.js releases. label Mar 18, 2025
@joyeecheung

Copy link
Copy Markdown
MemberAuthor

cc @marco-ippolito

@joyeecheungjoyeecheung added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 18, 2025
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @joyeecheung. Please 👍 to approve.

@joyeecheungjoyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 19, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 19, 2025
@nodejs-github-bot
nodejs-github-bot merged commit fe5817e into nodejs:mainMar 19, 2025
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in fe5817e

@joyeecheung

Copy link
Copy Markdown
MemberAuthor

@aduh95aduh95 added dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Mar 22, 2025
aduh95 pushed a commit that referenced this pull request Mar 22, 2025
The backported patches already include the commit that disables
the warning unless `--trace-require-module` is explicitly used.
Correct the changelog to match the status.
PR-URL: #57529Fixes: #57517
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
The backported patches already include the commit that disables
the warning unless `--trace-require-module` is explicitly used.
Correct the changelog to match the status.
PR-URL: #57529Fixes: #57517
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
The backported patches already include the commit that disables
the warning unless `--trace-require-module` is explicitly used.
Correct the changelog to match the status.
PR-URL: #57529Fixes: #57517
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
The backported patches already include the commit that disables
the warning unless `--trace-require-module` is explicitly used.
Correct the changelog to match the status.
PR-URL: #57529Fixes: #57517
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.fast-trackPRs that do not need to wait for 48 hours to land.releaseIssues and PRs related to Node.js releases.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v20.19.0 release notes - outdated messaging

6 participants

@joyeecheung@nodejs-github-bot@lpinca@richardlau@marco-ippolito@aduh95