Uh oh!
There was an error while loading. Please reload this page.
src, permission: make ERR_ACCESS_DENIED more descriptive - #57585
Merged
nodejs-github-bot merged 2 commits intoApr 3, 2025
Merged
src, permission: make ERR_ACCESS_DENIED more descriptive#57585nodejs-github-bot merged 2 commits into
nodejs-github-bot merged 2 commits into
Conversation
Collaborator
Review requested:
|
This commit also adds a suggestion flag (if exists) when ERR_ACCESS_DENIED is thrown, so users don't need to jump into the documentation to see how to manage that permission error.
RafaelGSSforce-pushed
the
improve-error-message-permission-model
branch
from
March 21, 2025 19:05
802f91c to
3c14972CompareCodecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #57585 +/- ##
==========================================
- Coverage 90.23% 90.23% -0.01%
==========================================
Files 629 630 +1 Lines 184947 185136 +189 Branches 36229 36237 +8 ==========================================
+ Hits 166882 167052 +170 - Misses 11017 11047 +30 + Partials 7048 7037 -11
🚀 New features to boost your workflow:
|
Contributor
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - src,permission: make ERR_ACCESS_DENIED more descriptive ⚠ - fixup! src,permission: make ERR_ACCESS_DENIED more descriptive ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/14195007818 |
Contributor
Failed to start CI- Validating Jenkins credentials ✔ Jenkins credentials valid - Starting PR CI job ✘ Failed to start PR CI: 200 OKhttps://github.com/nodejs/node/actions/runs/14196081383 |
nodejs-github-bot
commented
Apr 1, 2025
Collaborator
jasnell
approved these changes
Apr 1, 2025
nodejs-github-bot
commented
Apr 3, 2025
Collaborator
nodejs-github-bot
commented
Apr 3, 2025
Collaborator
Landed in 24e4a54 |
RafaelGSS added a commit
that referenced
this pull request
May 1, 2025
This commit also adds a suggestion flag (if exists) when ERR_ACCESS_DENIED is thrown, so users don't need to jump into the documentation to see how to manage that permission error. PR-URL: #57585 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS added a commit
that referenced
this pull request
May 2, 2025
This commit also adds a suggestion flag (if exists) when ERR_ACCESS_DENIED is thrown, so users don't need to jump into the documentation to see how to manage that permission error. PR-URL: #57585 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
May 6, 2025
This commit also adds a suggestion flag (if exists) when ERR_ACCESS_DENIED is thrown, so users don't need to jump into the documentation to see how to manage that permission error. PR-URL: #57585 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS added a commit
that referenced
this pull request
May 14, 2025
This commit also adds a suggestion flag (if exists) when ERR_ACCESS_DENIED is thrown, so users don't need to jump into the documentation to see how to manage that permission error. PR-URL: #57585 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
May 17, 2025
This commit also adds a suggestion flag (if exists) when ERR_ACCESS_DENIED is thrown, so users don't need to jump into the documentation to see how to manage that permission error. PR-URL: #57585 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
May 19, 2025
This commit also adds a suggestion flag (if exists) when ERR_ACCESS_DENIED is thrown, so users don't need to jump into the documentation to see how to manage that permission error. PR-URL: #57585 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit also adds a suggestion flag (if exists) when ERR_ACCESS_DENIED is thrown, so users don't need to jump into the documentation to see how to manage that permission error.