Skip to content

module: remove unnecessary readPackage function - #57596

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
dario-piotrowicz:dario/remove-readPackage-function
Apr 6, 2025
Merged

module: remove unnecessary readPackage function#57596
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
dario-piotrowicz:dario/remove-readPackage-function

Conversation

@dario-piotrowicz

@dario-piotrowiczdario-piotrowicz commented Mar 23, 2025

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-bot

nodejs-github-bot commented Mar 23, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-botnodejs-github-bot added module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. labels Mar 23, 2025
@codecov

codecovBot commented Mar 23, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (ffc1cf6) to head (1a7f26e).
Report is 80 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #57596 +/- ##
=======================================
Coverage 90.22% 90.22% =======================================
Files 630 630 Lines 185149 185117 -32 Branches 36236 36242 +6 =======================================
- Hits 167058 167030 -28 - Misses 11035 11038 +3 + Partials 7056 7049 -7
Files with missing linesCoverage Δ
lib/internal/modules/cjs/loader.js98.26% <100.00%> (ø)
lib/internal/modules/package_json_reader.js99.36% <ø> (-0.03%)⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 23, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 1, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65935/

@nodejs-github-bot

nodejs-github-bot commented Apr 5, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66059/

@nodejs-github-bot

nodejs-github-bot commented Apr 5, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66069/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 6, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 6, 2025
@nodejs-github-bot
nodejs-github-bot merged commit d7a1565 into nodejs:mainApr 6, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 6, 2025

Copy link
Copy Markdown
Collaborator

Landed in d7a1565

@dario-piotrowicz
dario-piotrowicz deleted the dario/remove-readPackage-function branch April 6, 2025 17:10
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@dario-piotrowicz@RafaelGSS
module: remove unnecessary readPackage function
7b6b07f
PR-URL: #57596
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@dario-piotrowicz@RafaelGSS
module: remove unnecessary readPackage function
6adbbe2
PR-URL: #57596
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@dario-piotrowicz@aduh95
module: remove unnecessary readPackage function
ae09f19
PR-URL: #57596
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@dario-piotrowicz@RafaelGSS
module: remove unnecessary readPackage function
9abeec1
PR-URL: #57596
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@dario-piotrowicz@aduh95
module: remove unnecessary readPackage function
7771bde
PR-URL: #57596
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@dario-piotrowicz@aduh95
module: remove unnecessary readPackage function
49ac1ce
PR-URL: #57596
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@dario-piotrowicz@aduh95
module: remove unnecessary readPackage function
9e6054e
PR-URL: #57596
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@ghostghost mentioned this pull request Jun 8, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@anonriganonriganonrig approved these changes
@JakobJingleheimerJakobJingleheimerJakobJingleheimer approved these changes
@aduh95aduh95aduh95 approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes
+2 more reviewers
@bjohansebasbjohansebasbjohansebas approved these changes
@jsumners-nrjsumners-nrjsumners-nr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.moduleIssues and PRs related to the module subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@dario-piotrowicz@nodejs-github-bot@jasnell@anonrig@JakobJingleheimer@aduh95@marco-ippolito@RaisinTen@bjohansebas@jsumners-nr