sqlite: enable common flags by geeksilva97 · Pull Request #57621 · nodejs/node

geeksilva97 · 2025-03-25T17:51:46Z

This PR enables flags that are common to other sqlite players in Node.js ecosystem:

This is related to #56476, even though it does not enable the RBU extension.

I see this as a good step toward the stabilization since it will make it easier for people from other dependencies.

nodejs-github-bot · 2025-03-25T17:51:50Z

Review requested:

@nodejs/gyp
@nodejs/security-wg
@nodejs/sqlite

geeksilva97 · 2025-03-25T17:52:47Z

Not sure whether this will be a problem, but this increases the binary size by 600KB.

cjihrig

Not saying whether or not we should land this, but https://github.com/nodejs/node/blob/main/deps/sqlite/unofficial.gni should be updated, and there should be at least one test for each new API to prevent regressions.

geeksilva97 · 2025-03-25T17:57:11Z

Not saying whether or not we should land this, but https://github.com/nodejs/node/blob/main/deps/sqlite/unofficial.gni should be updated, and there should be at least one test for each new API to prevent regressions.

Good point. Also, I think it would be good to have some benchmarks on sqlite implementations.

geeksilva97 · 2025-03-25T19:23:09Z

Not saying whether or not we should land this, but https://github.com/nodejs/node/blob/main/deps/sqlite/unofficial.gni should be updated, and there should be at least one test for each new API to prevent regressions.

@cjihrig , what's the difference between .gyp and .gni file?

cjihrig · 2025-03-25T19:30:37Z

what's the difference between .gyp and .gni file?

They are for two different build systems. The .gyp file is used by the official build. The .gni file is used by the unofficial GN build.

geeksilva97 · 2025-03-25T19:32:39Z

what's the difference between .gyp and .gni file?
They are for two different build systems. The .gyp file is used by the official build. The .gni file is used by the unofficial GN build.

Thank you!

cjihrig · 2025-03-25T19:42:35Z

even though it does not enable the RBU extension.

Why not? And why not the Geopoly extension?

geeksilva97 · 2025-03-25T20:16:35Z

even though it does not enable the RBU extension.
Why not? And why not the Geopoly extension?

For RBU, I didn't see it in better-sqlite3 or node-sqlite3. Geopoly seems like a good extension to have.

geeksilva97 · 2025-03-25T20:26:06Z

even though it does not enable the RBU extension.
Why not? And why not the Geopoly extension?
For RBU, I didn't see it in better-sqlite3 or node-sqlite3. Geopoly seems like a good extension to have.

On the other hand, the issue mentions the SQLite Amalgamation. I think we could have RBU enabled.

The amalgamation contains everything you need to integrate SQLite into a larger project

codecov · 2025-03-25T21:55:59Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (1b5b019) to head (c22f75e).
Report is 69 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #57621 +/- ##
==========================================
+ Coverage 90.22% 90.23% +0.01% 
==========================================
Files 630 630 Lines 185054 185055 +1 Branches 36254 36219 -35 ==========================================
+ Hits 166963 166985 +22 - Misses 11032 11037 +5 + Partials 7059 7033 -26

see 45 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

TheOneTheOnlyJJ

Small typo

cjihrig

One comment, but changes LGTM.

Co-authored-by: Colin Ihrig <cjihrig@gmail.com>

TheOneTheOnlyJJ · 2025-03-26T14:05:52Z

+ );
+ });
+
+ test('fts3 parenthesis', (t) => {


This is inconsistent with the rest, missing is enabled in its name.

cjihrig

Still unsure whether or not we want all of these enabled, but giving this a LGTM so it's not stalled.

PR-URL: #57621 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jlarmstrongiv · 2026-04-28T07:11:19Z

More common flags that are missing are SQLITE_ENABLE_UPDATE_DELETE_LIMIT and SQLITE_ENABLE_NULLS_LAST_IN_INDEX

22.13 exposes node:sqlite but SQLite was built without FTS5 until 22.16 (nodejs/node#57621). Co-authored-by: Cursor <cursoragent@cursor.com>

…gelog - Pin CI/security to Node 22.16 (node:sqlite + FTS5, nodejs/node#57621) - engines, .nvmrc, docs: require >=22.16.0 - Tests: storageGrowth nulls vs expect.anything(); EventLog CHECK relaxed - CHANGELOG [Unreleased]: cron exit validation (#1203) + Node bump - Biome-format cron exit validator / harness / install paths Co-authored-by: Cursor <cursoragent@cursor.com>

- Pin CI/security to Node 22.16 (node:sqlite + FTS5, nodejs/node#57621) - engines, .nvmrc, docs: require >=22.16.0; sync verify/maintenance copy - Tests: storageGrowth null handling; EventLog CHECK relaxed - CHANGELOG [Unreleased]: maintenance LLM tier + Node bump - Biome-format touched config/CLI files Co-authored-by: Cursor <cursoragent@cursor.com>

- Pin CI/security to Node 22.16 (node:sqlite + FTS5, nodejs/node#57621) - engines, .nvmrc, docs: require >=22.16.0; sync verify/maintenance copy - Tests: storageGrowth null handling; EventLog CHECK relaxed - CHANGELOG [Unreleased]: deprecated cron command handling + Node bump Co-authored-by: Cursor <cursoragent@cursor.com>

- Pin CI/security to Node 22.16 (node:sqlite + FTS5, nodejs/node#57621) - engines, .nvmrc, docs: require >=22.16.0; sync verify/maintenance copy - Tests: storageGrowth null handling; EventLog CHECK relaxed - CHANGELOG [Unreleased]: Node requirement under Changed Co-authored-by: Cursor <cursoragent@cursor.com>

* Initial plan * Add JSON output to config command, features command, and consolidate-episodes deprecation notice Agent-Logs-Url: https://github.com/markus-lassfolk/openclaw-hybrid-memory/sessions/25f77f4e-1ea6-444b-b0b2-60f98bd13a4d Co-authored-by: markus-lassfolk <3661143+markus-lassfolk@users.noreply.github.com> * Update CHANGELOG with new CLI commands and fixes Agent-Logs-Url: https://github.com/markus-lassfolk/openclaw-hybrid-memory/sessions/25f77f4e-1ea6-444b-b0b2-60f98bd13a4d Co-authored-by: markus-lassfolk <3661143+markus-lassfolk@users.noreply.github.com> * fix(ci): Node 22.13 for node:sqlite; Biome-format hybrid-mem CLI - CI/security: pin Node 22 jobs to 22.13 (22.12 needs --experimental-sqlite) - engines, .nvmrc, docs: require >=22.13.0; sync verify/maintenance copy - Format cmd-config and register-corrections-and-pipeline with Biome Co-authored-by: Cursor <cursoragent@cursor.com> * fix(ci): require Node 22.16 for node:sqlite FTS5 support 22.13 exposes node:sqlite but SQLite was built without FTS5 until 22.16 (nodejs/node#57621). Co-authored-by: Cursor <cursoragent@cursor.com> * test: align audit-health and event-log expectations with Vitest and schema - expect.anything() does not match null (storageGrowth delta fields) - EventLog no longer applies CHECK on event_type after relaxation migration Co-authored-by: Cursor <cursoragent@cursor.com> * fix(memory-hybrid): config JSON contract, format validation, consolidate shim - Versioned config-view JSON summary + wal/ambient/futureDateProtection toggles. - features command emits features-only JSON; validate config --format. - consolidate-episodes exits 0 with deprecation warning; changelog aligned. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com> Co-authored-by: markus-lassfolk <3661143+markus-lassfolk@users.noreply.github.com> Co-authored-by: Ralph <ralph@openclaw.dev> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: OpenClaw Agent <agent@openclaw.dev>

…1214) * Initial plan * fix: add timeout protection and partial result handling to audit-health - Add `status` field ("ok"|"partial"|"failed") and `errors` array to AuditHealthReport schema - Keep backward-compatible `ok` field (deprecated) - Add 5000-row LIMIT to implicitFeedbackPrefixHistogram query to prevent scanning huge fact tables - Wrap prefix histogram in try-catch with error tracking - Add 5-second timeout for LanceDB size calculation (getStorageSizes) - Update strict mode to check both status and ok fields - Update markdown printer to show errors section - Update tests to validate new schema fields Fixes hang on long-lived stores by bounding expensive operations. Agent-Logs-Url: https://github.com/markus-lassfolk/openclaw-hybrid-memory/sessions/64bfcd5d-27d4-4a78-b223-6142f3a0b1ab Co-authored-by: markus-lassfolk <3661143+markus-lassfolk@users.noreply.github.com> * docs: add CHANGELOG entry for audit-health timeout fix Agent-Logs-Url: https://github.com/markus-lassfolk/openclaw-hybrid-memory/sessions/64bfcd5d-27d4-4a78-b223-6142f3a0b1ab Co-authored-by: markus-lassfolk <3661143+markus-lassfolk@users.noreply.github.com> * fix(ci): Node 22.16 + FTS5; Vitest audit-health/event-log; changelog - Pin CI/security to Node 22.16 (node:sqlite + FTS5, nodejs/node#57621) - engines, .nvmrc, docs: require >=22.16.0; sync verify/maintenance copy - Tests: storageGrowth null handling; EventLog CHECK relaxed - CHANGELOG [Unreleased]: Node requirement under Changed Co-authored-by: Cursor <cursoragent@cursor.com> * fix(memory-hybrid): audit-health status, Lance size timeout, and changelog ref - Derive partial status when warnings or report errors exist; align legacy ok flag. - Record LanceDB du timeout in report.errors; kill du via execFile timeout. - Rename misleading EventLog test describe; changelog references #1214. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(memory-hybrid): detect implicit-feedback histogram truncation via LIMIT+1 Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com> Co-authored-by: markus-lassfolk <3661143+markus-lassfolk@users.noreply.github.com> Co-authored-by: Ralph <ralph@openclaw.dev> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: OpenClaw Agent <agent@openclaw.dev>

* Initial plan * Fix stale consolidate-episodes references in cron/verify * fix(ci): Node 22.16 + FTS5; Vitest audit-health/event-log; changelog - Pin CI/security to Node 22.16 (node:sqlite + FTS5, nodejs/node#57621) - engines, .nvmrc, docs: require >=22.16.0; sync verify/maintenance copy - Tests: storageGrowth null handling; EventLog CHECK relaxed - CHANGELOG [Unreleased]: deprecated cron command handling + Node bump Co-authored-by: Cursor <cursoragent@cursor.com> * fix(memory-hybrid): robust HM_EXIT scan for deprecated cron steps - Recursively collect recent .exit.txt under cron-hybrid-mem (flat + subdirs). - Per-file read isolation; escape regex metacharacters in deprecated tokens. - Tests: mkdtemp + cleanup; cover exit ledger path collection. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(memory-hybrid): skip deprecated-cron warnings for feature-gated jobs Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: openai-code-agent[bot] <242516109+Codex@users.noreply.github.com> Co-authored-by: Ralph <ralph@openclaw.dev> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: OpenClaw Agent <agent@openclaw.dev>

* Initial plan * feat(memory-hybrid): add maintenance LLM tier and routing warnings Co-authored-by: markus-lassfolk <3661143+markus-lassfolk@users.noreply.github.com> * fix(ci): Node 22.16 + FTS5; Vitest audit-health/event-log; changelog - Pin CI/security to Node 22.16 (node:sqlite + FTS5, nodejs/node#57621) - engines, .nvmrc, docs: require >=22.16.0; sync verify/maintenance copy - Tests: storageGrowth null handling; EventLog CHECK relaxed - CHANGELOG [Unreleased]: maintenance LLM tier + Node bump - Biome-format touched config/CLI files Co-authored-by: Cursor <cursoragent@cursor.com> * fix(memory-hybrid): align reflection routing with maintenance tier and docs - Route reflect/reflect-rules/reflect-meta through maintenance tier and default reflectionConfig.model from that tier. - Derive extraction heavy-model warnings from filtered tier preferences. - Correct distill.extractionModelTier schema/docs: unset defaults to nano. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(memory-hybrid): derive dream-cycle heavy warning from filtered maintenance tier Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: openai-code-agent[bot] <242516109+Codex@users.noreply.github.com> Co-authored-by: markus-lassfolk <3661143+markus-lassfolk@users.noreply.github.com> Co-authored-by: Ralph <ralph@openclaw.dev> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: OpenClaw Agent <agent@openclaw.dev>

…on (#1204) * Initial plan * Add exit ledger validation for cron jobs - Create cron-exit-validator.ts with structured validation - Add validate-cron-exit CLI command for internal use - Update cron job bash harness with validation instructions - Add comprehensive tests for exit ledger parsing and validation - Register new validation command in CLI Agent-Logs-Url: https://github.com/markus-lassfolk/openclaw-hybrid-memory/sessions/cd60b52e-d486-4166-b77f-63a3040389a2 Co-authored-by: markus-lassfolk <3661143+markus-lassfolk@users.noreply.github.com> * Add message normalization to fix obsolete cron commands - Update existing cron job messages when normalizeExisting=true - Remove obsolete command references (e.g., consolidate-episodes) - Convert tests to vitest format - All 14 tests passing Agent-Logs-Url: https://github.com/markus-lassfolk/openclaw-hybrid-memory/sessions/cd60b52e-d486-4166-b77f-63a3040389a2 Co-authored-by: markus-lassfolk <3661143+markus-lassfolk@users.noreply.github.com> * Add comprehensive documentation for cron exit validation - Document validation behavior and expected outcomes - Explain migration path for existing installations - Detail config-based skipping mechanism - List acceptance criteria and testing coverage Agent-Logs-Url: https://github.com/markus-lassfolk/openclaw-hybrid-memory/sessions/cd60b52e-d486-4166-b77f-63a3040389a2 Co-authored-by: markus-lassfolk <3661143+markus-lassfolk@users.noreply.github.com> * fix(ci): Node 22.16 + FTS5; Vitest audit-health/event-log tests; changelog - Pin CI/security to Node 22.16 (node:sqlite + FTS5, nodejs/node#57621) - engines, .nvmrc, docs: require >=22.16.0 - Tests: storageGrowth nulls vs expect.anything(); EventLog CHECK relaxed - CHANGELOG [Unreleased]: cron exit validation (#1203) + Node bump - Biome-format cron exit validator / harness / install paths Co-authored-by: Cursor <cursoragent@cursor.com> * fix(memory-hybrid): use Number.parseInt in cron-exit-validator (Biome error) Co-authored-by: Cursor <cursoragent@cursor.com> * fix(memory-hybrid): treat all-missing exit ledger as failed, not skipped Empty or step-less HM_EXIT cannot distinguish guard skip from abort before hm_step; report failure so validate-cron-exit surfaces the error. Co-authored-by: chatgpt-codex-connector <noreply@openai.com> Co-authored-by: Cursor <cursoragent@cursor.com> * fix(memory-hybrid): respect messageOverrides during cron normalizeExisting Apply overrides to payload.message for agentTurn jobs and skip canonical message replacement when a per-job override is provided. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(cron): treat empty exit ledger as skipped when log shows feature-gated skip Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com> Co-authored-by: markus-lassfolk <3661143+markus-lassfolk@users.noreply.github.com> Co-authored-by: Ralph <ralph@openclaw.dev> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: chatgpt-codex-connector <noreply@openai.com> Co-authored-by: OpenClaw Agent <agent@openclaw.dev>

nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Mar 25, 2025

geeksilva97 force-pushed the enable-common-sqlite-flags branch from e4b93b9 to 9590deeCompare March 25, 2025 17:53

cjihrig reviewed Mar 25, 2025
View reviewed changes

geeksilva97 force-pushed the enable-common-sqlite-flags branch from 9590dee to 0c1ec86Compare March 25, 2025 19:22

geeksilva97 commented Mar 25, 2025
View reviewed changes

Comment threadtest/parallel/test-sqlite.js Outdated

geeksilva97 force-pushed the enable-common-sqlite-flags branch from 0c1ec86 to 31c5aa5Compare March 25, 2025 19:28

TheOneTheOnlyJJ reviewed Mar 26, 2025
View reviewed changes

Comment threadtest/parallel/test-sqlite.js Outdated

sqlite: enable common flags
3f64dfa

geeksilva97 force-pushed the enable-common-sqlite-flags branch from 31c5aa5 to 3f64dfaCompare March 26, 2025 13:49

geeksilva97 commented Mar 26, 2025
View reviewed changes

Comment threadtest/parallel/test-sqlite.js

cjihrig reviewed Mar 26, 2025
View reviewed changes

Comment threadtest/parallel/test-sqlite.js Outdated

sqlite: apply review change
c22f75e
Co-authored-by: Colin Ihrig <cjihrig@gmail.com>

TheOneTheOnlyJJ reviewed Mar 26, 2025
View reviewed changes

Comment threadtest/parallel/test-sqlite.js Outdated

TheOneTheOnlyJJ mentioned this pull request Mar 26, 2025
Add dbhash and sqldiff utilities as JS APIs for working with SQLite #57637
Closed

cjihrig approved these changes Apr 3, 2025
View reviewed changes

cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 3, 2025

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 3, 2025

aduh95 pushed a commit that referenced this pull request May 6, 2025
sqlite: enable common flags
c92647b
PR-URL: #57621 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

RafaelGSS pushed a commit that referenced this pull request May 14, 2025
sqlite: enable common flags
61743f1
PR-URL: #57621 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request May 16, 2025
sqlite: enable common flags
05172fd
PR-URL: #57621 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request May 17, 2025
sqlite: enable common flags
dc98f2e
PR-URL: #57621 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

aduh95 pushed a commit that referenced this pull request May 18, 2025
sqlite: enable common flags
3fd205c
PR-URL: #57621 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

github-actionsBot mentioned this pull request May 19, 2025
2025-05-21, Version 22.16.0 'Jod' (LTS) #58388
Merged

aduh95 pushed a commit that referenced this pull request May 19, 2025
sqlite: enable common flags
ed9d2fd
PR-URL: #57621 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

geeksilva97 deleted the enable-common-sqlite-flags branch May 20, 2025 00:46

ghost mentioned this pull request Jun 8, 2025
### Notable Changes autofix-ci/action#28
Closed

TheOneTheOnlyJJ mentioned this pull request Jul 12, 2025
fix: missing SQLite builtin support in Node.js electron/electron#47706
Merged
3 tasks

TheOneTheOnlyJJ mentioned this pull request Jan 6, 2026
sqlite: enable Percentile extension #61295
Merged

cjihrig mentioned this pull request Feb 19, 2026
Memory FTS5 unavailable on macOS/Node 23: node:sqlite compiled without FTS5 support openclaw/openclaw#20987
Closed

Uh oh!

Uh oh!

Conversation

geeksilva97 commented Mar 25, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 25, 2025

Uh oh!

geeksilva97 commented Mar 25, 2025

Uh oh!

cjihrig left a comment

Choose a reason for hiding this comment

Uh oh!

geeksilva97 commented Mar 25, 2025

Uh oh!

geeksilva97 commented Mar 25, 2025

Uh oh!

Uh oh!

cjihrig commented Mar 25, 2025

Uh oh!

geeksilva97 commented Mar 25, 2025

Uh oh!

cjihrig commented Mar 25, 2025

Uh oh!

geeksilva97 commented Mar 25, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

geeksilva97 commented Mar 25, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecovBot commented Mar 25, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

TheOneTheOnlyJJ left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cjihrig left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TheOneTheOnlyJJMar 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cjihrig left a comment

Choose a reason for hiding this comment

Uh oh!

jlarmstrongiv commented Apr 28, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

geeksilva97 commented Mar 25, 2025•
edited
Loading

geeksilva97 commented Mar 25, 2025•
edited
Loading

geeksilva97 commented Mar 25, 2025•
edited
Loading

codecovBot commented Mar 25, 2025•
edited
Loading

jlarmstrongiv commented Apr 28, 2026•
edited
Loading