Uh oh!
There was an error while loading. Please reload this page.
worker: add ESM version examples to worker docs - #57645
Merged
Merged
Conversation
fisker
commented
Mar 27, 2025
ContributorAuthor
There was a problem hiding this comment.
ESM version can't conditional add exports like CJS, it should be fine to always add a export.
fiskerforce-pushed
the
worker_threads-esm-doc
branch
from
March 27, 2025 10:56
6d41acc to
e1eda74Comparefiskerforce-pushed
the
worker_threads-esm-doc
branch
from
March 27, 2025 11:01
e1eda74 to
132b6bfComparefiskerforce-pushed
the
worker_threads-esm-doc
branch
from
March 27, 2025 11:09
132b6bf to
c9a76b5Comparefisker
marked this pull request as ready for review
March 28, 2025 07:25
fiskerforce-pushed
the
worker_threads-esm-doc
branch
from
April 8, 2025 15:53
c9a76b5 to
328cb9aComparelpinca
approved these changes
Apr 19, 2025
nodejs-github-bot
commented
Apr 19, 2025
Collaborator
Landed in 0699a99 |
RafaelGSS pushed a commit
that referenced
this pull request
May 1, 2025
PR-URL: #57645 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
May 2, 2025
PR-URL: #57645 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
May 6, 2025
PR-URL: #57645 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
May 6, 2025
PR-URL: #57645 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
May 14, 2025
PR-URL: #57645 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #57645 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
May 17, 2025
PR-URL: #57645 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
May 18, 2025
PR-URL: #57645 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
May 19, 2025
PR-URL: #57645 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'use strict'directive to all cjs blocks, doing this only because there are blocks includes them, better add it consistentlynew Worker()in ESM version fromurl.fileURLToPath(import.meta.url)tonew URL(import.meta.url)