Skip to content

src: fix -Wunreachable-code-return in node_sea - #57664

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
codebytere:unreachable-code-return-sea
Apr 23, 2025
Merged

src: fix -Wunreachable-code-return in node_sea#57664
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
codebytere:unreachable-code-return-sea

Conversation

@codebytere

@codebyterecodebytere commented Mar 28, 2025

Copy link
Copy Markdown
Member

As in title - correct the following:

../../third_party/electron_node/src/node_sea.cc:641:10: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
641 | return false;
| ^~~~~
1 error generated.

@nodejs-github-bot

nodejs-github-bot commented Mar 28, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/single-executable

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications labels Mar 28, 2025
@codecov

This comment was marked as outdated.

Sign in to view
@codebyterecodebytere added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Mar 31, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. labels Apr 1, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Apr 19, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66369/

@codebyterecodebytere added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Apr 23, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 23, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 7bc37af into nodejs:mainApr 23, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 23, 2025

Copy link
Copy Markdown
Collaborator

Landed in 7bc37af

RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@codebytere@RafaelGSS
src: fix -Wunreachable-code-return in node_sea
44c2ef6
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@codebytere@RafaelGSS
src: fix -Wunreachable-code-return in node_sea
09206e9
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@codebytere@aduh95
src: fix -Wunreachable-code-return in node_sea
852bb62
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@codebytere@aduh95
src: fix -Wunreachable-code-return in node_sea
b6ab677
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@codebytere@RafaelGSS
src: fix -Wunreachable-code-return in node_sea
ab34e4c
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@codebytere@aduh95
src: fix -Wunreachable-code-return in node_sea
a6fd445
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@codebytere@aduh95
src: fix -Wunreachable-code-return in node_sea
b071d19
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@codebytere@aduh95
src: fix -Wunreachable-code-return in node_sea
0c7d952
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@codebytere@aduh95
src: fix -Wunreachable-code-return in node_sea
ca020fd
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
@codebytere@marco-ippolito
src: fix -Wunreachable-code-return in node_sea
30cc6c3
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
@codebytere@marco-ippolito
src: fix -Wunreachable-code-return in node_sea
a96eab5
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@marco-ippolitomarco-ippolito mentioned this pull request Jun 5, 2025
Merged
@ghostghost mentioned this pull request Jun 8, 2025
Closed
marco-ippolito pushed a commit that referenced this pull request Jun 10, 2025
@codebytere@marco-ippolito
src: fix -Wunreachable-code-return in node_sea
c01fd4c
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jun 11, 2025
@codebytere@marco-ippolito
src: fix -Wunreachable-code-return in node_sea
c0252cd
PR-URL: #57664
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@legendecaslegendecaslegendecas approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes
@joyeecheungjoyeecheungAwaiting requested review from joyeecheung
+3 more reviewers
@dsanders11dsanders11dsanders11 approved these changes
@aymen94aymen94aymen94 approved these changes
@tony-gotony-gotony-go approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.single-executableIssues and PRs related to single-executable applications

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@codebytere@nodejs-github-bot@lpinca@dsanders11@legendecas@aymen94@tony-go@RaisinTen@aduh95