Uh oh!
There was an error while loading. Please reload this page.
quic: fix debug log - #57689
Merged
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
jakecastelliforce-pushed
the
fix-quic-debug-typos
branch
from
March 30, 2025 11:01
c7737b2 to
5eda7aaCompareanonrig
approved these changes
Mar 30, 2025
lpinca
approved these changes
Mar 30, 2025
bjohansebas
approved these changes
Mar 30, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #57689 +/- ##
==========================================
- Coverage 90.23% 90.22% -0.01%
==========================================
Files 630 630 Lines 185055 185055 Branches 36221 36214 -7 ==========================================
- Hits 166984 166973 -11 - Misses 11043 11046 +3 - Partials 7028 7036 +8 🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Mar 30, 2025
cjihrig
commented
Mar 30, 2025
Contributor
I'm not sure this can currently be fast tracked because it requires a full CI run and the CI is locked down. |
jakecastelli
commented
Mar 30, 2025
MemberAuthor
oh yes, thanks for the reminder, forgot about the CI situation when I created the PR |
benjamingr
approved these changes
Mar 31, 2025
MoLow
approved these changes
Apr 1, 2025
nodejs-github-bot
commented
Apr 1, 2025
Collaborator
jasnell
commented
Apr 2, 2025
Member
Well, that and quic is no longer built by default in CI ;-) |
nodejs-github-bot
commented
Apr 3, 2025
Collaborator
Landed in 10cff7b |
RafaelGSS pushed a commit
that referenced
this pull request
May 1, 2025
PR-URL: #57689 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
RafaelGSS pushed a commit
that referenced
this pull request
May 2, 2025
PR-URL: #57689 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.