Uh oh!
There was an error while loading. Please reload this page.
tools: enable linter in test/fixtures/errors - #57701
Merged
Merged
Conversation
MoLow
approved these changes
Apr 1, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #57701 +/- ##
=======================================
Coverage 90.24% 90.25% =======================================
Files 630 630 Lines 184990 184990 Branches 36214 36220 +6 =======================================
+ Hits 166948 166957 +9 + Misses 11001 10997 -4 + Partials 7041 7036 -5 🚀 New features to boost your workflow:
|
jakecastelli
commented
Apr 4, 2025
Member
Just for the educational purpose - would this commit |
jakecastelli
approved these changes
Apr 4, 2025
aduh95
commented
Apr 4, 2025
ContributorAuthor
Yes definitely, it can only work if the PR is landed manually – which we have to do anyway because CQ refuses to land PR that touch test files without a full CI re-run, as it can't tell the changes are purely cosmetic. |
aduh95
commented
Apr 4, 2025
ContributorAuthor
Landed in caf478b |
RafaelGSS pushed a commit
that referenced
this pull request
May 1, 2025
PR-URL: #57701 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
May 2, 2025
PR-URL: #57701 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 added a commit
that referenced
this pull request
May 6, 2025
PR-URL: #57701 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
May 14, 2025
PR-URL: #57701 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 added a commit
that referenced
this pull request
May 17, 2025
PR-URL: #57701 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 added a commit
that referenced
this pull request
May 19, 2025
PR-URL: #57701 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.