Uh oh!
There was an error while loading. Please reload this page.
src: improve StringBytes error handling - #57706
Merged
Merged
Conversation
nodejs-github-bot
commented
Apr 1, 2025
Collaborator
Review requested:
|
jasnellforce-pushed
the
jasnell/string_bytes
branch
from
April 1, 2025 14:23
1fab9ca to
715f9aeCompareanonrig
reviewed
Apr 1, 2025
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
anonrig
approved these changes
Apr 3, 2025
aduh95
reviewed
Apr 5, 2025
Comment on lines
+188
to
-196
| args.GetReturnValue().Set(ret); | ||
| } | ||
| args.GetReturnValue().Set(ret); |
Contributor
There was a problem hiding this comment.
nit: I'd find it more readable to return on the error path, possibly with a comment, and keep the .Set() call on the top-level of the body of the function
aduh95
approved these changes
Apr 6, 2025
nodejs-github-bot
commented
Apr 6, 2025
Collaborator
Landed in 93644d5 |
RafaelGSS pushed a commit
that referenced
this pull request
May 1, 2025
PR-URL: #57706 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
May 2, 2025
PR-URL: #57706 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
commented
May 6, 2025
Contributor
Could you open a backport PR to v22.x-staging please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve error handling and the signature of
StringBytes::Encode(...).Also, mark the
node::Encode(...)C++ APIs as deprecated since those do not propagate errors correctly. Addednode::TryEncode(...)replacements that properly returnMaybeLocal<String>and propagate errors.