Uh oh!
There was an error while loading. Please reload this page.
src: fixup fs SyncCall to propagate errors correctly - #57711
Closed
jasnell wants to merge 2 commits into
Closed
Conversation
Propagate errors correctly in the SyncCall utility. Previously the test case would trigger a crash.
jasnellforce-pushed
the
jasnell/fs-sync-crash-fix
branch
from
April 1, 2025 17:30
a76b761 to
75ebfddCompareCodecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #57711 +/- ##
=======================================
Coverage 90.22% 90.23% =======================================
Files 630 630 Lines 185073 185092 +19 Branches 36222 36231 +9 =======================================
+ Hits 166990 167018 +28 + Misses 11044 11037 -7 + Partials 7039 7037 -2
🚀 New features to boost your workflow:
|
aduh95
approved these changes
Apr 1, 2025
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
anonrig
approved these changes
Apr 3, 2025
jasnell added a commit
that referenced
this pull request
Apr 3, 2025
Propagate errors correctly in the SyncCall utility. Previously the test case would trigger a crash. PR-URL: #57711 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
jasnell
commented
Apr 3, 2025
MemberAuthor
Landed in 538c813 |
RafaelGSS pushed a commit
that referenced
this pull request
May 1, 2025
Propagate errors correctly in the SyncCall utility. Previously the test case would trigger a crash. PR-URL: #57711 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit
that referenced
this pull request
May 2, 2025
Propagate errors correctly in the SyncCall utility. Previously the test case would trigger a crash. PR-URL: #57711 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95
commented
May 6, 2025
Contributor
Test is crashing on v22.x-staging with this change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate errors correctly in the SyncCall utility.
Previously the test case would trigger a crash.