Skip to content

doc: process.execve is only unavailable for Windows - #57726

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
thunder-coding:execve-android-doc
Apr 4, 2025
Merged

doc: process.execve is only unavailable for Windows#57726
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
thunder-coding:execve-android-doc

Conversation

@thunder-coding

@thunder-codingthunder-coding commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

execve() call is available on Android as well. When process.execve was first added, it seems like no one checked if that is actually available on Android as well and works out of the box as __POSIX__ is defined on Android. process.execve call seems to behave just as fine as on Linux environment in my testing, so just make the docs specify it.

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Apr 2, 2025
Comment threaddoc/api/process.md Outdated
execve() call is available on Android as well. When process.execve was
first added, it seems like no one checked if that is actually available
on Android as well and works out of the box as __POSIX__ is defined on
Android. process.execve call seems to behave just as fine as on Linux
environment in my testing, so just make the docs specify it.
@aduh95

Copy link
Copy Markdown
Contributor

I guess Android is POSIX, it's listed as "Mostly POSIX-compliant" on https://en.wikipedia.org/wiki/POSIX#POSIX-oriented_operating_systems. Given that it seems to be possible to get POSIX for Windows, I wonder if we should keep mentioning POSIX 🤔

@aduh95
aduh95 requested a review from ShogunPandaApril 2, 2025 11:53
@targos

Copy link
Copy Markdown
Member

Also, I don't know if IBMI is POSIX but it doesn't support execve: https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi74-ppc64/1883/#showFailuresLink

@nodejs/platform-ibmi

@ShogunPanda

Copy link
Copy Markdown
Contributor

@targos It seems the syscall exists but we get a EPERM error somehow.

https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi74-ppc64/1883/testReport/junit/(root)/parallel/test_process_execve_permission_granted/

@ShogunPandaShogunPanda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 2, 2025
@abmusse

Copy link
Copy Markdown
Contributor

Hi @targos I'm currently investigating why we are getting back EPERM error on IBM i for some reason, execve does exist and I tested it using a simple C program.

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 3, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 4, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 78e2f99 into nodejs:mainApr 4, 2025
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 78e2f99

@abmusseabmusse mentioned this pull request Apr 15, 2025
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
execve() call is available on Android as well. When process.execve was
first added, it seems like no one checked if that is actually available
on Android as well and works out of the box as __POSIX__ is defined on
Android. process.execve call seems to behave just as fine as on Linux
environment in my testing, so just make the docs specify it.
PR-URL: #57726
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
execve() call is available on Android as well. When process.execve was
first added, it seems like no one checked if that is actually available
on Android as well and works out of the box as __POSIX__ is defined on
Android. process.execve call seems to behave just as fine as on Linux
environment in my testing, so just make the docs specify it.
PR-URL: #57726
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
execve() call is available on Android as well. When process.execve was
first added, it seems like no one checked if that is actually available
on Android as well and works out of the box as __POSIX__ is defined on
Android. process.execve call seems to behave just as fine as on Linux
environment in my testing, so just make the docs specify it.
PR-URL: #57726
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
execve() call is available on Android as well. When process.execve was
first added, it seems like no one checked if that is actually available
on Android as well and works out of the box as __POSIX__ is defined on
Android. process.execve call seems to behave just as fine as on Linux
environment in my testing, so just make the docs specify it.
PR-URL: #57726
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
execve() call is available on Android as well. When process.execve was
first added, it seems like no one checked if that is actually available
on Android as well and works out of the box as __POSIX__ is defined on
Android. process.execve call seems to behave just as fine as on Linux
environment in my testing, so just make the docs specify it.
PR-URL: #57726
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95 pushed a commit that referenced this pull request May 19, 2025
execve() call is available on Android as well. When process.execve was
first added, it seems like no one checked if that is actually available
on Android as well and works out of the box as __POSIX__ is defined on
Android. process.execve call seems to behave just as fine as on Linux
environment in my testing, so just make the docs specify it.
PR-URL: #57726
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@ghostghost mentioned this pull request Jun 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.processIssues and PRs related to the process subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@thunder-coding@aduh95@targos@ShogunPanda@abmusse@nodejs-github-bot@ljharb@marco-ippolito